Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: webrtc/base/thread_checker_unittest.cc

Issue 2384693002: Test RTC_DCHECK_IS_ON instead of checking DCHECK_ALWAYS_ON everywhere (Closed)
Patch Set: !!! Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/thread_checker.h ('k') | webrtc/common_audio/resampler/push_resampler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 // Borrowed from Chromium's src/base/threading/thread_checker_unittest.cc. 11 // Borrowed from Chromium's src/base/threading/thread_checker_unittest.cc.
12 12
13 #include <memory> 13 #include <memory>
14 14
15 #include "webrtc/test/gtest.h" 15 #include "webrtc/test/gtest.h"
16 #include "webrtc/base/checks.h" 16 #include "webrtc/base/checks.h"
17 #include "webrtc/base/constructormagic.h" 17 #include "webrtc/base/constructormagic.h"
18 #include "webrtc/base/task_queue.h" 18 #include "webrtc/base/task_queue.h"
19 #include "webrtc/base/thread.h" 19 #include "webrtc/base/thread.h"
20 #include "webrtc/base/thread_checker.h" 20 #include "webrtc/base/thread_checker.h"
21 21
22 // Duplicated from base/threading/thread_checker.h so that we can be 22 // Duplicated from base/threading/thread_checker.h so that we can be
23 // good citizens there and undef the macro. 23 // good citizens there and undef the macro.
24 #if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON) 24 #define ENABLE_THREAD_CHECKER RTC_DCHECK_IS_ON
25 #define ENABLE_THREAD_CHECKER 1
26 #else
27 #define ENABLE_THREAD_CHECKER 0
28 #endif
29 25
30 namespace rtc { 26 namespace rtc {
31 27
32 namespace { 28 namespace {
33 29
34 // Simple class to exercise the basics of ThreadChecker. 30 // Simple class to exercise the basics of ThreadChecker.
35 // Both the destructor and DoStuff should verify that they were 31 // Both the destructor and DoStuff should verify that they were
36 // called on the same thread as the constructor. 32 // called on the same thread as the constructor.
37 class ThreadCheckerClass : public ThreadChecker { 33 class ThreadCheckerClass : public ThreadChecker {
38 public: 34 public:
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 243
248 int var_thread_ ACCESS_ON(thread_); 244 int var_thread_ ACCESS_ON(thread_);
249 int var_checker_ GUARDED_BY(checker_); 245 int var_checker_ GUARDED_BY(checker_);
250 int var_queue_ ACCESS_ON(queue_); 246 int var_queue_ ACCESS_ON(queue_);
251 }; 247 };
252 248
253 // Just in case we ever get lumped together with other compilation units. 249 // Just in case we ever get lumped together with other compilation units.
254 #undef ENABLE_THREAD_CHECKER 250 #undef ENABLE_THREAD_CHECKER
255 251
256 } // namespace rtc 252 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/thread_checker.h ('k') | webrtc/common_audio/resampler/push_resampler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698