Add a flag for aborting on stack overflow.

Add a flag for aborting on stack overflow.

This is useful for correctness fuzzing where different compilers might
overflow the stack in different points.

Committed: https://crrev.com/6ca8c11fb37439de345c2e954c4c097b46055db3
Cr-Commit-Position: refs/heads/master@{#39862}

[Jarin, 2016-09-29 09:34:38]

The CQ bit was checked by jarin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 09:34:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2016-09-29 09:35:22]

jarin@chromium.org changed reviewers:
+ machenbach@chromium.org, mstarzinger@chromium.org

[Jarin, 2016-09-29 09:35:23]

Could you take a look, please?

[commit-bot: I haz the power, 2016-09-29 10:01:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 10:01:12]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-09-29 10:07:54]

Unfortunately there seem to be more places that throw a "stack overflow"
exception directly without going through the {Isolate::StackOverflow} choke
point. I count a total of 22 uses if {MessageTemplate::kStackOverflow}
throughout the code-base. Are there any plans to unify those?

https://codereview.chromium.org/2381773003/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2381773003/diff/1/src/isolate.cc#newcode929
src/isolate.cc:929: V8_Fatal(__FILE__, __LINE__, "Aborting on stack overflow");
nit: Any reason not to use the "FATAL" macro instead?

[Michael Achenbach, 2016-09-29 10:12:57]

Thanks for working on this. Can't add more enlightenment to the details.

Maybe we can try out this version and see how many stack overflows it catches?

[Michael Starzinger, 2016-09-29 11:47:40]

LGTM (modulo the V8_Fatal vs FATAL nit). I am fine with unifying all paths in
follow-up CLs.

[Jarin, 2016-09-29 11:52:12]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2016-09-29 11:52:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2381773003/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2016-09-29 11:52:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 12:20:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-29 12:20:41]

Description was changed from

==========
Add a flag for aborting on stack overflow.

This is useful for correctness fuzzing where different compilers might
overflow the stack in different points.
==========

to

==========
Add a flag for aborting on stack overflow.

This is useful for correctness fuzzing where different compilers might
overflow the stack in different points.

Committed: https://crrev.com/6ca8c11fb37439de345c2e954c4c097b46055db3
Cr-Commit-Position: refs/heads/master@{#39862}
==========

[commit-bot: I haz the power, 2016-09-29 12:20:42]

Patchset 2 (id:??) landed as
https://crrev.com/6ca8c11fb37439de345c2e954c4c097b46055db3
Cr-Commit-Position: refs/heads/master@{#39862}