Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2381313003: Making ContinueSSL synchronously set the state to "open". (Closed)

Created:
4 years, 2 months ago by Taylor Brandstetter
Modified:
4 years, 2 months ago
Reviewers:
pthatcher2, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Making ContinueSSL synchronously set the state to "open". It was recently made asynchronous, and this broke some downstream tests. BUG=webrtc:6387 TBR=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/fe69a74ba831cde0660987f3b3d825a9659d233f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M webrtc/base/opensslstreamadapter.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Taylor Brandstetter
4 years, 2 months ago (2016-09-30 21:41:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2381313003/1
4 years, 2 months ago (2016-09-30 21:41:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/17087)
4 years, 2 months ago (2016-09-30 23:07:26 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fe69a74ba831cde0660987f3b3d825a9659d233f Cr-Commit-Position: refs/heads/master@{#14463}
4 years, 2 months ago (2016-10-01 00:34:45 UTC) #9
Taylor Brandstetter
Committed patchset #1 (id:1) manually as fe69a74ba831cde0660987f3b3d825a9659d233f (presubmit successful).
4 years, 2 months ago (2016-10-01 00:34:47 UTC) #11
pthatcher2
4 years, 2 months ago (2016-10-06 17:29:09 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698