Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: webrtc/base/opensslstreamadapter.cc

Issue 2381313003: Making ContinueSSL synchronously set the state to "open". (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/opensslstreamadapter.cc
diff --git a/webrtc/base/opensslstreamadapter.cc b/webrtc/base/opensslstreamadapter.cc
index 6a42003968cf4ff74400818c826b5ff69d069492..d2f3bc49781d7d9aa8646df6d0956465b6a92a85 100644
--- a/webrtc/base/opensslstreamadapter.cc
+++ b/webrtc/base/opensslstreamadapter.cc
@@ -865,10 +865,12 @@ int OpenSSLStreamAdapter::ContinueSSL() {
// SE_OPEN. If we need a client certificate fingerprint and don't have
// it yet, we'll instead signal SE_OPEN in SetPeerCertificateDigest.
//
- // Post the event asynchronously to unwind the stack. The
- // caller of ContinueSSL may be the same object listening
- // for these events and may not be prepared for reentrancy.
- PostEvent(SE_OPEN | SE_READ | SE_WRITE, 0);
+ // TODO(deadbeef): Post this event asynchronously to unwind the stack.
+ // The caller of ContinueSSL may be the same object listening for these
+ // events and may not be prepared for reentrancy.
+ // PostEvent(SE_OPEN | SE_READ | SE_WRITE, 0);
+ StreamAdapterInterface::OnEvent(stream(), SE_OPEN | SE_READ | SE_WRITE,
+ 0);
}
break;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698