Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2377933002: Add trusty builder / tester for chromium.linux. (Closed)

Created:
4 years, 2 months ago by Yoshisato Yanagisawa
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add trusty builder / tester for chromium.linux. BUG=644641 BUG=646285

Patch Set 1 #

Total comments: 4

Patch Set 2 : use corresponding builder for test. #

Patch Set 3 : removed Trusty Builder / Tester from CQ builders. #

Total comments: 1

Patch Set 4 : removed test generators #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -120 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_linux.py View 1 2 3 1 chunk +112 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 1 2 3 3 chunks +22 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder_Trusty.json View 1 7 chunks +9 lines, -9 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder_Trusty__dbg_.json View 1 7 chunks +9 lines, -9 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder_Trusty__dbg__32_.json View 1 7 chunks +9 lines, -9 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests_Trusty.json View 1 18 chunks +25 lines, -25 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests_Trusty__dbg__1_.json View 1 17 chunks +32 lines, -32 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests_Trusty__dbg__1__32_.json View 1 18 chunks +25 lines, -25 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_trusty_dbg_32_ng.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_trusty_dbg_ng.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_trusty_rel_ng.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty_dbg_32_ng.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty_dbg_ng.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Yoshisato Yanagisawa
4 years, 2 months ago (2016-09-28 03:54:15 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/2377933002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py File scripts/slave/recipe_modules/chromium_tests/chromium_linux.py (right): https://codereview.chromium.org/2377933002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py#newcode181 scripts/slave/recipe_modules/chromium_tests/chromium_linux.py:181: 'parent_buildername': 'Linux Builder', Please use corresponding Trusty builders for ...
4 years, 2 months ago (2016-09-28 19:13:50 UTC) #3
Yoshisato Yanagisawa
https://codereview.chromium.org/2377933002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py File scripts/slave/recipe_modules/chromium_tests/chromium_linux.py (right): https://codereview.chromium.org/2377933002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py#newcode181 scripts/slave/recipe_modules/chromium_tests/chromium_linux.py:181: 'parent_buildername': 'Linux Builder', On 2016/09/28 19:13:50, Paweł Hajdan Jr. ...
4 years, 2 months ago (2016-09-29 10:04:02 UTC) #4
Paweł Hajdan Jr.
LGTM w/comment https://codereview.chromium.org/2377933002/diff/40001/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py File scripts/slave/recipe_modules/chromium_tests/chromium_linux.py (right): https://codereview.chromium.org/2377933002/diff/40001/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py#newcode176 scripts/slave/recipe_modules/chromium_tests/chromium_linux.py:176: 'test_generators': [ Test generators are no longer ...
4 years, 2 months ago (2016-09-29 22:28:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377933002/60001
4 years, 2 months ago (2016-10-03 02:44:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/31a13fb0e80ead10)
4 years, 2 months ago (2016-10-03 02:52:02 UTC) #10
Yoshisato Yanagisawa
4 years, 2 months ago (2016-10-03 04:54:46 UTC) #11 
let me merge this to https://codereview.chromium.org/2357493005/ because CQ
reject the commit with non-matching recipe and master.

Powered by Google App Engine
This is Rietveld 408576698