Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2377283002: [crankshaft] Move is_tracking_positions predicate. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Move is_tracking_positions predicate. This moves the Hydrogen-specific {is_tracking_positions} predicate which also depends on the --hydrogen-track-positions flag into the Crankshaft directory and removes it from the more general {CompilationInfo}. R=bmeurer@chromium.org Committed: https://crrev.com/c615b6eea11bf12bd4a6570e56cc41f634cd52b2 Cr-Commit-Position: refs/heads/master@{#39913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -36 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compilation-info.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/compilation-info.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.h View 5 chunks +9 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 20 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Starzinger
Benedikt: PTAL. Tobias: FYI.
4 years, 2 months ago (2016-09-29 10:13:21 UTC) #4
Benedikt Meurer
Nice. LGTM
4 years, 2 months ago (2016-09-30 10:43:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377283002/1
4 years, 2 months ago (2016-09-30 10:56:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 11:22:20 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 11:22:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c615b6eea11bf12bd4a6570e56cc41f634cd52b2
Cr-Commit-Position: refs/heads/master@{#39913}

Powered by Google App Engine
This is Rietveld 408576698