Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: webrtc/common_video/h264/pps_parser_unittest.cc

Issue 2373393002: Support for parsing CABAC coded bitstreams (Closed)
Patch Set: Add support for CABAC in bitstream parser Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/common_video/h264/pps_parser_unittest.cc
diff --git a/webrtc/common_video/h264/pps_parser_unittest.cc b/webrtc/common_video/h264/pps_parser_unittest.cc
index 8be8b23ee3882723b52622aa665bc6b276c0f04b..91493d8cf8ee3c2f3e57c204e2313c5f23d96d4a 100644
--- a/webrtc/common_video/h264/pps_parser_unittest.cc
+++ b/webrtc/common_video/h264/pps_parser_unittest.cc
@@ -46,7 +46,7 @@ void WritePps(const PpsParser::PpsState& pps,
// seq_parameter_set_id: ue(v)
bit_buffer.WriteExponentialGolomb(pps.sps_id);
// entropy_coding_mode_flag: u(1)
- bit_buffer.WriteBits(kIgnored, 1);
+ bit_buffer.WriteBits(pps.entropy_coding_mode_flag, 1);
// bottom_field_pic_order_in_frame_present_flag: u(1)
bit_buffer.WriteBits(pps.bottom_field_pic_order_in_frame_present_flag ? 1 : 0,
1);
@@ -182,6 +182,8 @@ class PpsParserTest : public ::testing::Test {
parsed_pps_->bottom_field_pic_order_in_frame_present_flag);
EXPECT_EQ(pps.weighted_pred_flag, parsed_pps_->weighted_pred_flag);
EXPECT_EQ(pps.weighted_bipred_idc, parsed_pps_->weighted_bipred_idc);
+ EXPECT_EQ(pps.entropy_coding_mode_flag,
+ parsed_pps_->entropy_coding_mode_flag);
EXPECT_EQ(pps.redundant_pic_cnt_present_flag,
parsed_pps_->redundant_pic_cnt_present_flag);
EXPECT_EQ(pps.pic_init_qp_minus26, parsed_pps_->pic_init_qp_minus26);
@@ -204,6 +206,7 @@ TEST_F(PpsParserTest, MaxPps) {
generated_pps_.redundant_pic_cnt_present_flag = 1; // 1 bit value.
generated_pps_.weighted_bipred_idc = (1 << 2) - 1; // 2 bit value.
generated_pps_.weighted_pred_flag = true;
+ generated_pps_.entropy_coding_mode_flag = true;
generated_pps_.id = 2;
generated_pps_.sps_id = 1;
RunTest();

Powered by Google App Engine
This is Rietveld 408576698