Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/common_video/h264/pps_parser.cc

Issue 2373393002: Support for parsing CABAC coded bitstreams (Closed)
Patch Set: Add support for CABAC in bitstream parser Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/common_video/h264/pps_parser.h ('k') | webrtc/common_video/h264/pps_parser_unittest.cc » ('j') | webrtc/modules/video_coding/utility/h264_bitstream_parser_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_video/h264/pps_parser.cc
diff --git a/webrtc/common_video/h264/pps_parser.cc b/webrtc/common_video/h264/pps_parser.cc
index a48d27bfc7fd8c2706b78dc7b72b41a12d429ac4..fcabc91aa726ebf7bc9385cea3f90cb9cda6fde9 100644
--- a/webrtc/common_video/h264/pps_parser.cc
+++ b/webrtc/common_video/h264/pps_parser.cc
@@ -82,9 +82,7 @@ rtc::Optional<PpsParser::PpsState> PpsParser::ParseInternal(
// entropy_coding_mode_flag: u(1)
uint32_t entropy_coding_mode_flag;
RETURN_EMPTY_ON_FAIL(bit_buffer->ReadBits(&entropy_coding_mode_flag, 1));
- // TODO(pbos): Implement CABAC support if spotted in the wild.
- RTC_CHECK(entropy_coding_mode_flag == 0)
- << "Don't know how to parse CABAC streams.";
+ pps.entropy_coding_mode_flag = !!entropy_coding_mode_flag;
stefan-webrtc 2016/09/30 13:33:09 I'd also prefer != 0.
kthelgason 2016/09/30 14:09:48 You guys are no fun :(
// bottom_field_pic_order_in_frame_present_flag: u(1)
uint32_t bottom_field_pic_order_in_frame_present_flag;
RETURN_EMPTY_ON_FAIL(
« no previous file with comments | « webrtc/common_video/h264/pps_parser.h ('k') | webrtc/common_video/h264/pps_parser_unittest.cc » ('j') | webrtc/modules/video_coding/utility/h264_bitstream_parser_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698