Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2373353002: Android: Remove onOutputFormatRequest from the VideoCapturer interface (Closed)

Created:
4 years, 2 months ago by magjed_webrtc
Modified:
4 years, 2 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Remove onOutputFormatRequest from the VideoCapturer interface Remove onOutputFormatRequest from the VideoCapturer interface and from all implementations of that interface. Apps should now use VideoSource.adaptOutputFormat() instead. BUG=webrtc:6391 Committed: https://crrev.com/ff9793c600d81af8a64e5610998763d2358bcb32 Cr-Commit-Position: refs/heads/master@{#14428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M webrtc/api/android/java/src/org/webrtc/CameraCapturer.java View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/ScreenCapturerAndroid.java View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/VideoCapturer.java View 4 chunks +0 lines, -18 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java View 2 chunks +0 lines, -21 lines 0 comments Download
M webrtc/api/android/jni/androidvideotracksource_jni.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
magjed_webrtc
Sami - please take a look.
4 years, 2 months ago (2016-09-28 11:18:46 UTC) #3
sakal
lgtm
4 years, 2 months ago (2016-09-28 14:07:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2373353002/1
4 years, 2 months ago (2016-09-29 07:39:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 09:14:34 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 09:14:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff9793c600d81af8a64e5610998763d2358bcb32
Cr-Commit-Position: refs/heads/master@{#14428}

Powered by Google App Engine
This is Rietveld 408576698