Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java

Issue 2373353002: Android: Remove onOutputFormatRequest from the VideoCapturer interface (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java
diff --git a/webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java b/webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java
index 9f90f5381ff0c7d68f0090cce67f2b2317afd75c..ec447abf706ae6396ccd11bdf14ef64650b19870 100644
--- a/webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java
+++ b/webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java
@@ -171,20 +171,6 @@ public class VideoCapturerAndroid implements
}
}
- // Requests a new output format from the video capturer. Captured frames
- // by the camera will be scaled/or dropped by the video capturer.
- // It does not matter if width and height are flipped. I.E, |width| = 640, |height| = 480 produce
- // the same result as |width| = 480, |height| = 640.
- // TODO(magjed/perkj): Document what this function does. Change name?
- @Override
- public void onOutputFormatRequest(final int width, final int height, final int framerate) {
- maybePostOnCameraThread(new Runnable() {
- @Override public void run() {
- onOutputFormatRequestOnCameraThread(width, height, framerate);
- }
- });
- }
-
// Reconfigure the camera to capture in a new format. This should only be called while the camera
// is running.
@Override
@@ -546,13 +532,6 @@ public class VideoCapturerAndroid implements
Logging.d(TAG, "switchCameraOnCameraThread done");
}
- private void onOutputFormatRequestOnCameraThread(int width, int height, int framerate) {
- checkIsOnCameraThread();
- Logging.d(TAG, "onOutputFormatRequestOnCameraThread: " + width + "x" + height +
- "@" + framerate);
- frameObserver.onOutputFormatRequest(width, height, framerate);
- }
-
private int getDeviceOrientation() {
int orientation = 0;
« no previous file with comments | « webrtc/api/android/java/src/org/webrtc/VideoCapturer.java ('k') | webrtc/api/android/jni/androidvideotracksource_jni.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698