Delete macsocketserver.h and related files.

Delete macsocketserver.h and related files.

BUG=webrtc:6424
Committed: https://crrev.com/c7901c6491ec675e8c80497ecba71a4a39fc94ed
Cr-Commit-Position: refs/heads/master@{#14571}

[nisse-webrtc, 2016-09-26 14:13:42]

nisse@webrtc.org changed reviewers:
+ perkj@webrtc.org

[pthatcher1, 2016-10-03 22:45:07]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2016-10-03 22:45:08]

If we delete this, will it still be possible to make OSX native apps?  If so,
with the Unix/POSIX socket server?

[nisse-webrtc, 2016-10-04 08:25:31]

On 2016/10/03 22:45:08, pthatcher1 wrote:
> If we delete this, will it still be possible to make OSX native apps?  If so,
> with the Unix/POSIX socket server?

Not sure... Per, do you know if we build any example programs for Mac OSX?
Whatever we build seems to 
work fine without this mac socketserver.

[nisse-webrtc, 2016-10-06 10:05:29]

nisse@webrtc.org changed reviewers:
+ kthelgason@webrtc.org

[nisse-webrtc, 2016-10-06 10:05:30]

+ kthelgason@, do you know if we build any osx apps by default, and whether or
not macsocketserver is totally obsolete?

[kthelgason, 2016-10-06 11:23:20]

On 2016/10/06 10:05:30, nisse-webrtc wrote:
> + kthelgason@, do you know if we build any osx apps by default, and whether or
> not macsocketserver is totally obsolete?

We have AppRTCMobile, and that builds for mac as well. I'm not sure it uses any
of this code though, and I'd be glad to be rid of it.

You may want to build AppRTCDemo on a macOS machine, and just verify that
everything works.

[nisse-webrtc, 2016-10-06 11:48:41]

On 2016/10/06 11:23:20, kthelgason wrote:
> On 2016/10/06 10:05:30, nisse-webrtc wrote:
> > + kthelgason@, do you know if we build any osx apps by default, and whether
or
> > not macsocketserver is totally obsolete?
> 
> We have AppRTCMobile, and that builds for mac as well. I'm not sure it uses
any
> of this code though, and I'd be glad to be rid of it.
> 
> You may want to build AppRTCDemo on a macOS machine, and just verify that
> everything works.

There's nothing in the webrtc which includes the three header files deleted in
this cl. And I've also checked the log of a build on the mac_rel bot, and it
does build AppRTCMobile. So deleting these files look safe to me.

[kthelgason, 2016-10-06 11:50:26]

On 2016/10/06 11:48:41, nisse-webrtc wrote:
> There's nothing in the webrtc which includes the three header files deleted in
> this cl. And I've also checked the log of a build on the mac_rel bot, and it
> does build AppRTCMobile. So deleting these files look safe to me.

Ok, great. lgtm!

[kthelgason, 2016-10-06 11:50:27]

On 2016/10/06 11:48:41, nisse-webrtc wrote:
> There's nothing in the webrtc which includes the three header files deleted in
> this cl. And I've also checked the log of a build on the mac_rel bot, and it
> does build AppRTCMobile. So deleting these files look safe to me.

Ok, great. lgtm!

[kthelgason, 2016-10-06 11:51:04]

https://codereview.webrtc.org/2369013002/diff/20001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (left):

https://codereview.webrtc.org/2369013002/diff/20001/webrtc/base/BUILD.gn#oldc...
webrtc/base/BUILD.gn:520: "macwindowpicker.h",
Can this stuff go as well?

[pthatcher2, 2016-10-06 16:27:33]

pthatcher@chromium.org changed reviewers:
+ pthatcher@chromium.org

[pthatcher2, 2016-10-06 16:27:33]

lgtm

[nisse-webrtc, 2016-10-07 07:04:05]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-10-07 07:04:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2016-10-07 07:05:17]

On 2016/10/06 11:51:04, kthelgason wrote:
> https://codereview.webrtc.org/2369013002/diff/20001/webrtc/base/BUILD.gn
> File webrtc/base/BUILD.gn (left):
> 
>
https://codereview.webrtc.org/2369013002/diff/20001/webrtc/base/BUILD.gn#oldc...
> webrtc/base/BUILD.gn:520: "macwindowpicker.h",
> Can this stuff go as well?

Needs a little investigation, when I did an initial check a week or two ago, it
appeared used.

[commit-bot: I haz the power, 2016-10-07 07:20:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 07:20:26]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9047)

[nisse-webrtc, 2016-10-07 12:36:27]

nisse@webrtc.org changed reviewers:
+ tommi@webrtc.org

[nisse-webrtc, 2016-10-07 12:36:27]

Tommi, OWNER's approval needed to delete these old mac files. PTAL.

[tommi, 2016-10-07 12:38:57]

rs lgtm

[nisse-webrtc, 2016-10-07 12:40:17]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-10-07 12:40:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-07 12:57:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-07 12:57:31]

Description was changed from

==========
Delete macsocketserver.h and related files.

BUG=webrtc:6424
==========

to

==========
Delete macsocketserver.h and related files.

BUG=webrtc:6424

Committed: https://crrev.com/c7901c6491ec675e8c80497ecba71a4a39fc94ed
Cr-Commit-Position: refs/heads/master@{#14571}
==========

[commit-bot: I haz the power, 2016-10-07 12:57:33]

Patchset 2 (id:??) landed as
https://crrev.com/c7901c6491ec675e8c80497ecba71a4a39fc94ed
Cr-Commit-Position: refs/heads/master@{#14571}