Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2368933002: Remove duplicated entry for bwe_simulations.cc (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove duplicated entry for bwe_simulations.cc Since modules_unittests already depends on remote_bitrate_estimator:bwe_simulator and the bwe_simulations.cc source was added to that target in https://codereview.webrtc.org/2296253002 there's no point having it added here. BUG=webrtc:6323 NOTRY=True NOPRESUBMIT=True NOTREECHECKS=True Committed: https://crrev.com/464382da7168ab18e57b5bd05740d9f68b464da5 Cr-Commit-Position: refs/heads/master@{#14380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
kjellander_webrtc
4 years, 2 months ago (2016-09-26 07:45:41 UTC) #2
stefan-webrtc
lgtm
4 years, 2 months ago (2016-09-26 07:46:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2368933002/1
4 years, 2 months ago (2016-09-26 07:52:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2368933002/1
4 years, 2 months ago (2016-09-26 10:00:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 10:00:04 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 10:00:15 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/464382da7168ab18e57b5bd05740d9f68b464da5
Cr-Commit-Position: refs/heads/master@{#14380}

Powered by Google App Engine
This is Rietveld 408576698