Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2368123003: Delete referencecountedsingletonfactory.h. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete referencecountedsingletonfactory.h. Unused since cl https://codereview.webrtc.org/1715043002 BUG=webrtc:6424 Committed: https://crrev.com/cacee524c1118be2699566034628da7eda8b4e42 Cr-Commit-Position: refs/heads/master@{#14501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -294 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/base/referencecountedsingletonfactory.h View 1 chunk +0 lines, -159 lines 0 comments Download
D webrtc/base/referencecountedsingletonfactory_unittest.cc View 1 chunk +0 lines, -132 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
nisse-webrtc
PTAL. This appear unused, and I think solenberg deleted the last use of it.
4 years, 2 months ago (2016-09-26 11:41:24 UTC) #3
the sun
Sorry, I missed that. lgtm
4 years, 2 months ago (2016-09-26 11:47:56 UTC) #4
pthatcher1
lgtm
4 years, 2 months ago (2016-10-03 22:32:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2368123003/1
4 years, 2 months ago (2016-10-04 07:31:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-04 09:31:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2368123003/1
4 years, 2 months ago (2016-10-04 14:13:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 14:21:52 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 14:22:04 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cacee524c1118be2699566034628da7eda8b4e42
Cr-Commit-Position: refs/heads/master@{#14501}

Powered by Google App Engine
This is Rietveld 408576698