Remove webrtc/sound/ subdir.

Remove webrtc/sound/ subdir.

Now that DeviceManager and DeviceInfo are gone, this code is unused.

BUG=webrtc:5579
Committed: https://crrev.com/e0897c043b3526d6952b6bc79f108f5902ceafe6
Cr-Commit-Position: refs/heads/master@{#12040}

[the sun, 2016-02-23 20:41:27]

solenberg@webrtc.org changed reviewers:
+ kjellander@webrtc.org, pthatcher@webrtc.org

[the sun, 2016-02-23 20:41:28]

Remove unused Linux sound system interface code, following
https://codereview.webrtc.org/1715883002/

[kjellander_webrtc, 2016-02-23 21:19:20]

Nice! Deleting code is great. lgtm

Can you file a BUG= and reference it? 
Will you also communicate this downstream and to discuss-webrtc@?

[the sun, 2016-02-23 21:40:24]

Description was changed from

==========
Remove webrtc/sound/ subdir.

BUG=
==========

to

==========
Remove webrtc/sound/ subdir.

BUG=webrtc:5579
==========

[the sun, 2016-02-23 21:42:04]

On 2016/02/23 21:19:20, kjellander (webrtc) wrote:
> Nice! Deleting code is great. lgtm
> 
> Can you file a BUG= and reference it? 
> Will you also communicate this downstream and to discuss-webrtc@?

Filed a bug. Is this considered part of the public API?

[kjellander_webrtc, 2016-02-23 22:00:11]

On 2016/02/23 21:42:04, the sun wrote:
> On 2016/02/23 21:19:20, kjellander (webrtc) wrote:
> > Nice! Deleting code is great. lgtm
> > 
> > Can you file a BUG= and reference it? 
> > Will you also communicate this downstream and to discuss-webrtc@?
> 
> Filed a bug. Is this considered part of the public API?

I guess not (looking at
https://chromium.googlesource.com/external/webrtc/+/master/PRESUBMIT.py) so you
can skip the communication then :)

[the sun, 2016-02-23 22:21:37]

On 2016/02/23 22:00:11, kjellander (webrtc) wrote:
> On 2016/02/23 21:42:04, the sun wrote:
> > On 2016/02/23 21:19:20, kjellander (webrtc) wrote:
> > > Nice! Deleting code is great. lgtm
> > > 
> > > Can you file a BUG= and reference it? 
> > > Will you also communicate this downstream and to discuss-webrtc@?
> > 
> > Filed a bug. Is this considered part of the public API?
> 
> I guess not (looking at
> https://chromium.googlesource.com/external/webrtc/+/master/PRESUBMIT.py) so
you
> can skip the communication then :)

Ah, well, thanks for pointing me there, found another reference to webrtc/sound
in the cpplint list. I believe they are all gone now though. :)

[pthatcher1, 2016-02-23 23:52:12]

lgtm

[kjellander_webrtc, 2016-02-29 19:37:31]

Wait, this does not lgtm. 
webrtc/media/devices/linuxdevicemanager.cc is referencing webrtc/sound, which
also shows in the failed linux trybot for PS#2.

[the sun, 2016-02-29 19:39:49]

On 2016/02/29 19:37:31, kjellander (webrtc) wrote:
> Wait, this does not lgtm. 
> webrtc/media/devices/linuxdevicemanager.cc is referencing webrtc/sound, which
> also shows in the failed linux trybot for PS#2.

Yes, https://codereview.webrtc.org/1715883002/ must be landed first, which is
why I haven't submitted it yet, and which is why the first comment on this CL
says it is "following" the other CL. Sorry for being unclear. :)

[the sun, 2016-03-01 19:10:04]

On 2016/02/29 19:39:49, the sun wrote:
> On 2016/02/29 19:37:31, kjellander (webrtc) wrote:
> > Wait, this does not lgtm. 
> > webrtc/media/devices/linuxdevicemanager.cc is referencing webrtc/sound,
which
> > also shows in the failed linux trybot for PS#2.
> 
> Yes, https://codereview.webrtc.org/1715883002/ must be landed first, which is
> why I haven't submitted it yet, and which is why the first comment on this CL
> says it is "following" the other CL. Sorry for being unclear. :)

kjellander@, are you ok with this being submitted after DeviceManager kicks the
bucket?

[kjellander_webrtc, 2016-03-01 20:57:11]

On 2016/03/01 19:10:04, the sun wrote:
> On 2016/02/29 19:39:49, the sun wrote:
> > On 2016/02/29 19:37:31, kjellander (webrtc) wrote:
> > > Wait, this does not lgtm. 
> > > webrtc/media/devices/linuxdevicemanager.cc is referencing webrtc/sound,
> which
> > > also shows in the failed linux trybot for PS#2.
> > 
> > Yes, https://codereview.webrtc.org/1715883002/ must be landed first, which
is
> > why I haven't submitted it yet, and which is why the first comment on this
CL
> > says it is "following" the other CL. Sorry for being unclear. :)
> 
> kjellander@, are you ok with this being submitted after DeviceManager kicks
the
> bucket?

Yeah, that'll be great. Posted a few comments on the other CL first though,
before I can approve this.

[the sun, 2016-03-02 15:00:59]

On 2016/03/01 20:57:11, kjellander (webrtc) wrote:
> On 2016/03/01 19:10:04, the sun wrote:
> > On 2016/02/29 19:39:49, the sun wrote:
> > > On 2016/02/29 19:37:31, kjellander (webrtc) wrote:
> > > > Wait, this does not lgtm. 
> > > > webrtc/media/devices/linuxdevicemanager.cc is referencing webrtc/sound,
> > which
> > > > also shows in the failed linux trybot for PS#2.
> > > 
> > > Yes, https://codereview.webrtc.org/1715883002/ must be landed first, which
> is
> > > why I haven't submitted it yet, and which is why the first comment on this
> CL
> > > says it is "following" the other CL. Sorry for being unclear. :)
> > 
> > kjellander@, are you ok with this being submitted after DeviceManager kicks
> the
> > bucket?
> 
> Yeah, that'll be great. Posted a few comments on the other CL first though,
> before I can approve this.

PTAL; I think we have resolved the issues with
https://codereview.webrtc.org/1715883002/ now.

[kjellander_webrtc, 2016-03-03 10:01:38]

On 2016/03/02 15:00:59, the sun wrote:
> On 2016/03/01 20:57:11, kjellander (webrtc) wrote:
> > On 2016/03/01 19:10:04, the sun wrote:
> > > On 2016/02/29 19:39:49, the sun wrote:
> > > > On 2016/02/29 19:37:31, kjellander (webrtc) wrote:
> > > > > Wait, this does not lgtm. 
> > > > > webrtc/media/devices/linuxdevicemanager.cc is referencing
webrtc/sound,
> > > which
> > > > > also shows in the failed linux trybot for PS#2.
> > > > 
> > > > Yes, https://codereview.webrtc.org/1715883002/ must be landed first,
which
> > is
> > > > why I haven't submitted it yet, and which is why the first comment on
this
> > CL
> > > > says it is "following" the other CL. Sorry for being unclear. :)
> > > 
> > > kjellander@, are you ok with this being submitted after DeviceManager
kicks
> > the
> > > bucket?
> > 
> > Yeah, that'll be great. Posted a few comments on the other CL first though,
> > before I can approve this.
> 
> PTAL; I think we have resolved the issues with
> https://codereview.webrtc.org/1715883002/ now.

With https://codereview.chromium.org/1760453002/ landed, the Chromium references
are removed.
Assuming you're able to provide good answers to Zeke's comments about existing
users in https://codereview.webrtc.org/1715883002 this lgtm now. 
Make sure to rebase+run trybots on this one after landing
https://codereview.webrtc.org/1715883002/

[the sun, 2016-03-17 10:56:39]

Description was changed from

==========
Remove webrtc/sound/ subdir.

BUG=webrtc:5579
==========

to

==========
Remove webrtc/sound/ subdir.

Now that DeviceManager and DeviceInfo are gone, this code is unused.

BUG=webrtc:5579
==========

[the sun, 2016-03-17 11:02:55]

The CQ bit was checked by solenberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 11:03:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715043002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715043002/120001

[commit-bot: I haz the power, 2016-03-17 13:03:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 13:03:33]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2016-03-17 15:31:47]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2016-03-17 15:31:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
pthatcher@webrtc.org, kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1715043002/#ps140001 (title:
"rebase")

[commit-bot: I haz the power, 2016-03-17 15:32:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715043002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715043002/140001

[commit-bot: I haz the power, 2016-03-17 15:37:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 15:37:51]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4215)

[the sun, 2016-03-17 16:33:34]

solenberg@webrtc.org changed reviewers:
+ tommi@webrtc.org

[the sun, 2016-03-17 16:33:35]

Adding tommi@ (webrtc/ OWNERS)

[tommi, 2016-03-17 18:07:14]

rs lgtm

[the sun, 2016-03-17 18:19:54]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2016-03-17 18:19:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715043002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715043002/140001

[commit-bot: I haz the power, 2016-03-17 18:23:04]

Description was changed from

==========
Remove webrtc/sound/ subdir.

Now that DeviceManager and DeviceInfo are gone, this code is unused.

BUG=webrtc:5579
==========

to

==========
Remove webrtc/sound/ subdir.

Now that DeviceManager and DeviceInfo are gone, this code is unused.

BUG=webrtc:5579
==========

[commit-bot: I haz the power, 2016-03-17 18:23:05]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-03-17 18:23:10]

Description was changed from

==========
Remove webrtc/sound/ subdir.

Now that DeviceManager and DeviceInfo are gone, this code is unused.

BUG=webrtc:5579
==========

to

==========
Remove webrtc/sound/ subdir.

Now that DeviceManager and DeviceInfo are gone, this code is unused.

BUG=webrtc:5579

Committed: https://crrev.com/e0897c043b3526d6952b6bc79f108f5902ceafe6
Cr-Commit-Position: refs/heads/master@{#12040}
==========

[commit-bot: I haz the power, 2016-03-17 18:23:12]

Patchset 8 (id:??) landed as
https://crrev.com/e0897c043b3526d6952b6bc79f108f5902ceafe6
Cr-Commit-Position: refs/heads/master@{#12040}