Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2367743002: Removing a useless ctor in AudioNetworkAdaptorImpl. (Closed)

Created:
4 years, 3 months ago by minyue-webrtc
Modified:
4 years, 1 month ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing a useless ctor in AudioNetworkAdaptorImpl. BUG=webrtc:6303 Committed: https://crrev.com/fd8e33d3ad2602bd7e81adae92e17d99190afd24 Cr-Commit-Position: refs/heads/master@{#14384}

Patch Set 1 #

Messages

Total messages: 27 (14 generated)
minyue-webrtc
Hi Karl, This is actually what you pointed out in https://codereview.webrtc.org/2356763002/ But I misinterpreted your ...
4 years, 3 months ago (2016-09-23 11:44:10 UTC) #3
kwiberg-webrtc
lgtm
4 years, 3 months ago (2016-09-23 11:45:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2367743002/1
4 years, 3 months ago (2016-09-23 11:53:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/14557)
4 years, 3 months ago (2016-09-23 12:02:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2367743002/1
4 years, 2 months ago (2016-09-26 09:18:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 2 months ago (2016-09-26 11:19:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2367743002/1
4 years, 2 months ago (2016-09-26 11:41:03 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 2 months ago (2016-09-26 13:41:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2367743002/1
4 years, 2 months ago (2016-09-26 13:44:16 UTC) #18
commit-bot: I haz the power
Exceeded global retry quota
4 years, 2 months ago (2016-09-26 15:44:47 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2367743002/1
4 years, 2 months ago (2016-09-26 18:07:16 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 18:46:45 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:46:49 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd8e33d3ad2602bd7e81adae92e17d99190afd24
Cr-Commit-Position: refs/heads/master@{#14384}

Powered by Google App Engine
This is Rietveld 408576698