Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.h

Issue 2367743002: Removing a useless ctor in AudioNetworkAdaptorImpl. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 14 matching lines...) Expand all
25 class AudioNetworkAdaptorImpl final : public AudioNetworkAdaptor { 25 class AudioNetworkAdaptorImpl final : public AudioNetworkAdaptor {
26 public: 26 public:
27 struct Config { 27 struct Config {
28 Config(); 28 Config();
29 ~Config(); 29 ~Config();
30 const Clock* clock; 30 const Clock* clock;
31 }; 31 };
32 32
33 AudioNetworkAdaptorImpl( 33 AudioNetworkAdaptorImpl(
34 const Config& config, 34 const Config& config,
35 std::unique_ptr<ControllerManager> controller_manager);
36
37 // Dependency injection for testing.
38 AudioNetworkAdaptorImpl(
39 const Config& config,
40 std::unique_ptr<ControllerManager> controller_manager, 35 std::unique_ptr<ControllerManager> controller_manager,
41 std::unique_ptr<DebugDumpWriter> debug_dump_writer = nullptr); 36 std::unique_ptr<DebugDumpWriter> debug_dump_writer = nullptr);
42 37
43 ~AudioNetworkAdaptorImpl() override; 38 ~AudioNetworkAdaptorImpl() override;
44 39
45 void SetUplinkBandwidth(int uplink_bandwidth_bps) override; 40 void SetUplinkBandwidth(int uplink_bandwidth_bps) override;
46 41
47 void SetUplinkPacketLossFraction(float uplink_packet_loss_fraction) override; 42 void SetUplinkPacketLossFraction(float uplink_packet_loss_fraction) override;
48 43
49 void SetRtt(int rtt_ms) override; 44 void SetRtt(int rtt_ms) override;
(...skipping 17 matching lines...) Expand all
67 std::unique_ptr<DebugDumpWriter> debug_dump_writer_; 62 std::unique_ptr<DebugDumpWriter> debug_dump_writer_;
68 63
69 Controller::NetworkMetrics last_metrics_; 64 Controller::NetworkMetrics last_metrics_;
70 65
71 RTC_DISALLOW_COPY_AND_ASSIGN(AudioNetworkAdaptorImpl); 66 RTC_DISALLOW_COPY_AND_ASSIGN(AudioNetworkAdaptorImpl);
72 }; 67 };
73 68
74 } // namespace webrtc 69 } // namespace webrtc
75 70
76 #endif // WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_AUDIO_NETWORK_ADAPT OR_IMPL_H_ 71 #endif // WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_AUDIO_NETWORK_ADAPT OR_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698