Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2366883002:
Renaming a proto target in GYP for audio network adaptor. (Closed)
|
Created:
4 years, 3 months ago by minyue-webrtc Modified:
4 years, 2 months ago CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRenaming a proto target in GYP for audio network adaptor.
It was incorrectly named for GYP in https://codereview.webrtc.org/2365723002
This makes the target name be the same for GN and GYP.
BUG=webrtc:6303
NOTRY=True
Committed: https://crrev.com/6d4c8c307e39264584096311064233ed9a5bf1bc
Cr-Commit-Position: refs/heads/master@{#14366}
Patch Set 1 #
Total comments: 2
Patch Set 2 : fixing #Messages
Total messages: 16 (8 generated)
Description was changed from ========== Renaming a proto target in GYP for audio network adaptor. BUG=webrtc:6303 ========== to ========== Renaming a proto target in GYP for audio network adaptor. BUG=webrtc:6303 ==========
minyue@webrtc.org changed reviewers: + henrik.lundin@webrtc.org, kjellander@webrtc.org
https://codereview.webrtc.org/2366883002/diff/1/webrtc/modules/audio_coding/a... File webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor.gypi (right): https://codereview.webrtc.org/2366883002/diff/1/webrtc/modules/audio_coding/a... webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor.gypi:39: 'dependencies': ['debug_dump_proto'], do you need to update the name here too?
Description was changed from ========== Renaming a proto target in GYP for audio network adaptor. BUG=webrtc:6303 ========== to ========== Renaming a proto target in GYP for audio network adaptor. It was incorrectly named for GYP in https://codereview.webrtc.org/2365723002 This makes the target name be the same for GN and GYP. BUG=webrtc:6303 ==========
PTAL thanks!
Description was changed from ========== Renaming a proto target in GYP for audio network adaptor. It was incorrectly named for GYP in https://codereview.webrtc.org/2365723002 This makes the target name be the same for GN and GYP. BUG=webrtc:6303 ========== to ========== Renaming a proto target in GYP for audio network adaptor. It was incorrectly named for GYP in https://codereview.webrtc.org/2365723002 This makes the target name be the same for GN and GYP. BUG=webrtc:6303 NOTRY=True ==========
lgtm I added NOTRY=True for you.
https://codereview.webrtc.org/2366883002/diff/1/webrtc/modules/audio_coding/a... File webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor.gypi (right): https://codereview.webrtc.org/2366883002/diff/1/webrtc/modules/audio_coding/a... webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor.gypi:39: 'dependencies': ['debug_dump_proto'], On 2016/09/23 08:31:04, danilchap wrote: > do you need to update the name here too? right thanks!
The CQ bit was checked by minyue@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from kjellander@webrtc.org Link to the patchset: https://codereview.webrtc.org/2366883002/#ps20001 (title: "fixing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Renaming a proto target in GYP for audio network adaptor. It was incorrectly named for GYP in https://codereview.webrtc.org/2365723002 This makes the target name be the same for GN and GYP. BUG=webrtc:6303 NOTRY=True ========== to ========== Renaming a proto target in GYP for audio network adaptor. It was incorrectly named for GYP in https://codereview.webrtc.org/2365723002 This makes the target name be the same for GN and GYP. BUG=webrtc:6303 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Renaming a proto target in GYP for audio network adaptor. It was incorrectly named for GYP in https://codereview.webrtc.org/2365723002 This makes the target name be the same for GN and GYP. BUG=webrtc:6303 NOTRY=True ========== to ========== Renaming a proto target in GYP for audio network adaptor. It was incorrectly named for GYP in https://codereview.webrtc.org/2365723002 This makes the target name be the same for GN and GYP. BUG=webrtc:6303 NOTRY=True Committed: https://crrev.com/6d4c8c307e39264584096311064233ed9a5bf1bc Cr-Commit-Position: refs/heads/master@{#14366} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6d4c8c307e39264584096311064233ed9a5bf1bc Cr-Commit-Position: refs/heads/master@{#14366}
Message was sent while issue was closed.
lgtm |
