Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2365723002: Relanding of "Adding debug dump to audio network adaptor." (Closed)

Created:
4 years, 3 months ago by minyue-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Relanding of "Adding debug dump to audio network adaptor." The original CL was https://codereview.webrtc.org/2356763002 but got reverted https://codereview.webrtc.org/2362003002/. The error was that ana_debug_dump_proto as a proto_library was placed under rtc_include_tests. BUG=webrtc:6303 Committed: https://crrev.com/25f6a39181c9162d26c12ceb8af69e405b2da9e5 Cr-Commit-Position: refs/heads/master@{#14363}

Patch Set 1 #

Patch Set 2 : fixing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -22 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 3 chunks +18 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor.gypi View 2 chunks +28 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.h View 3 chunks +17 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc View 5 chunks +31 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc View 4 chunks +76 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/controller.h View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/debug_dump.proto View 1 chunk +30 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.h View 1 chunk +40 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc View 1 chunk +135 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor.h View 1 chunk +4 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_coding/audio_network_adaptor/mock/mock_debug_dump_writer.h View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
minyue-webrtc
Hi Michael and Karl, Our CL had a mistake and was reverted. I try to ...
4 years, 3 months ago (2016-09-22 21:51:27 UTC) #3
kwiberg-webrtc
lgtm
4 years, 3 months ago (2016-09-22 21:55:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2365723002/20001
4 years, 3 months ago (2016-09-23 05:15:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 05:23:25 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 05:23:35 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25f6a39181c9162d26c12ceb8af69e405b2da9e5
Cr-Commit-Position: refs/heads/master@{#14363}

Powered by Google App Engine
This is Rietveld 408576698