Make RtpSenderAudio not inherit from DtmfQueue

- Make RtpSenderAudio not inherit from DtmfQueue.
- Remove unused method DtmfQueue::ResetDTMF()

BUG=webrtc:2795
Committed: https://crrev.com/d3d230f7885a9fca32754221b9c625b739f308b3
Cr-Commit-Position: refs/heads/master@{#14376}

[the sun, 2016-09-23 18:41:38]

Description was changed from

==========
Send side multi-rate DTMF.

BUG=webrtc:2795
==========

to

==========
- Make RtpSenderAudio not inherit from DtmfQueue.
- Remove unused method DtmfQueue::ResetDtmf()

BUG=webrtc:2795
==========

[the sun, 2016-09-23 18:42:34]

Description was changed from

==========
- Make RtpSenderAudio not inherit from DtmfQueue.
- Remove unused method DtmfQueue::ResetDtmf()

BUG=webrtc:2795
==========

to

==========
- Make RtpSenderAudio not inherit from DtmfQueue.
- Remove unused method DtmfQueue::ResetDTMF()

BUG=webrtc:2795
==========

[the sun, 2016-09-23 18:42:34]

solenberg@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[danilchap, 2016-09-23 19:05:22]

https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/dtmf_queue.h (left):

https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/dtmf_queue.h:22: virtual ~DTMFqueue();
because of critsect_, DTMFqueue has non-trivial destrucor, better make it
explicit,
i.e. restore the destructor, remove only virtual.

https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h (left):

https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h:28: virtual ~RTPSenderAudio();
same for this destructor: no virtual, but keep explicit

[the sun, 2016-09-23 19:15:07]

https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/dtmf_queue.h (left):

https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/dtmf_queue.h:22: virtual ~DTMFqueue();
On 2016/09/23 19:05:22, danilchap wrote:
> because of critsect_, DTMFqueue has non-trivial destrucor, better make it
> explicit,
> i.e. restore the destructor, remove only virtual.

Done.

https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h (left):

https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h:28: virtual ~RTPSenderAudio();
On 2016/09/23 19:05:22, danilchap wrote:
> same for this destructor: no virtual, but keep explicit

Done.

[the sun, 2016-09-23 19:18:06]

On 2016/09/23 19:15:07, the sun wrote:
>
https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
> File webrtc/modules/rtp_rtcp/source/dtmf_queue.h (left):
> 
>
https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
> webrtc/modules/rtp_rtcp/source/dtmf_queue.h:22: virtual ~DTMFqueue();
> On 2016/09/23 19:05:22, danilchap wrote:
> > because of critsect_, DTMFqueue has non-trivial destrucor, better make it
> > explicit,
> > i.e. restore the destructor, remove only virtual.
> 
> Done.
> 
>
https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
> File webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h (left):
> 
>
https://codereview.webrtc.org/2365873002/diff/20001/webrtc/modules/rtp_rtcp/s...
> webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h:28: virtual
~RTPSenderAudio();
> On 2016/09/23 19:05:22, danilchap wrote:
> > same for this destructor: no virtual, but keep explicit
> 
> Done.

PTAL

[danilchap, 2016-09-23 19:21:42]

lgtm

[the sun, 2016-09-23 19:25:28]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2016-09-23 19:25:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-23 20:10:48]

Description was changed from

==========
- Make RtpSenderAudio not inherit from DtmfQueue.
- Remove unused method DtmfQueue::ResetDTMF()

BUG=webrtc:2795
==========

to

==========
- Make RtpSenderAudio not inherit from DtmfQueue.
- Remove unused method DtmfQueue::ResetDTMF()

BUG=webrtc:2795
==========

[commit-bot: I haz the power, 2016-09-23 20:10:49]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-09-23 20:10:58]

Description was changed from

==========
- Make RtpSenderAudio not inherit from DtmfQueue.
- Remove unused method DtmfQueue::ResetDTMF()

BUG=webrtc:2795
==========

to

==========
- Make RtpSenderAudio not inherit from DtmfQueue.
- Remove unused method DtmfQueue::ResetDTMF()

BUG=webrtc:2795

Committed: https://crrev.com/d3d230f7885a9fca32754221b9c625b739f308b3
Cr-Commit-Position: refs/heads/master@{#14376}
==========

[commit-bot: I haz the power, 2016-09-23 20:10:59]

Patchset 4 (id:??) landed as
https://crrev.com/d3d230f7885a9fca32754221b9c625b739f308b3
Cr-Commit-Position: refs/heads/master@{#14376}