Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2362373002: Remove chain of methods in RtpRtcp module to get current payload frequency for RTCP SRs (Closed)

Created:
4 years, 2 months ago by the sun
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove chain of methods in RtpRtcp module to get current payload frequency for RTCP SRs, which anyway was stuck to defaults for video/audio. BUG=webrtc:2795, webrtc:6458 Committed: https://crrev.com/b19d288c94014b1b4167771846573871255a875b Cr-Commit-Position: refs/heads/master@{#14476}

Patch Set 1 #

Patch Set 2 : remove from feedback struct #

Patch Set 3 : add back frequency field to struct, add constant for audio rtp rate #

Patch Set 4 : removed RTCPSender::FeedbackState #

Patch Set 5 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -24 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
the sun
Take a look at this. Current behavior is maintained. Question is - does it need ...
4 years, 2 months ago (2016-09-23 19:47:44 UTC) #2
the sun
4 years, 2 months ago (2016-09-26 18:55:42 UTC) #4
the sun
ping...
4 years, 2 months ago (2016-09-28 07:57:00 UTC) #5
danilchap
On 2016/09/28 07:57:00, the sun wrote: > ping... lgtm I think proper fix is desired. ...
4 years, 2 months ago (2016-09-28 08:19:34 UTC) #6
stefan-webrtc
lgtm, but perhaps follow up with a fix?
4 years, 2 months ago (2016-09-28 10:22:52 UTC) #7
the sun
On 2016/09/28 10:22:52, stefan-webrtc (holmer) wrote: > lgtm, but perhaps follow up with a fix? ...
4 years, 2 months ago (2016-10-03 08:02:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2362373002/80001
4 years, 2 months ago (2016-10-03 08:02:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-10-03 10:03:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2362373002/80001
4 years, 2 months ago (2016-10-03 12:59:01 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-03 13:22:28 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 13:22:37 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b19d288c94014b1b4167771846573871255a875b
Cr-Commit-Position: refs/heads/master@{#14476}

Powered by Google App Engine
This is Rietveld 408576698