Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 2364473005: Hooking up target audio bitrate to audio network adaptor. (Closed)

Created:
4 years, 3 months ago by minyue-webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Hooking up target audio bitrate to audio network adaptor. After the landing of BitrateController, it is time to hook up the network data (target_audio_bitrate_bps) required by BitrateController. BUG=webrtc:6303 Committed: https://crrev.com/e5e632f8737442add11123826fce0d68f55b0b4c Cr-Commit-Position: refs/heads/master@{#14406}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -14 lines) Patch
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc View 2 chunks +20 lines, -13 lines 2 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc View 4 chunks +24 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor.h View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (9 generated)
minyue-webrtc
Hi Michael and Henrik, Please take a look at this small CL. Thanks! https://codereview.webrtc.org/2364473005/diff/1/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc File ...
4 years, 3 months ago (2016-09-23 07:39:43 UTC) #3
hlundin-webrtc
lgtm https://codereview.webrtc.org/2364473005/diff/1/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc File webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc (right): https://codereview.webrtc.org/2364473005/diff/1/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc#newcode62 webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc:62: void AudioNetworkAdaptorImpl::SetReceiverFrameLengthRange( On 2016/09/23 07:39:43, minyue-webrtc wrote: > ...
4 years, 2 months ago (2016-09-26 15:16:51 UTC) #4
michaelt
lgtm
4 years, 2 months ago (2016-09-27 11:53:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2364473005/1
4 years, 2 months ago (2016-09-27 12:02:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-09-27 14:03:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2364473005/1
4 years, 2 months ago (2016-09-27 14:14:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-09-27 16:15:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2364473005/1
4 years, 2 months ago (2016-09-27 19:45:45 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 19:54:22 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 19:54:31 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5e632f8737442add11123826fce0d68f55b0b4c
Cr-Commit-Position: refs/heads/master@{#14406}

Powered by Google App Engine
This is Rietveld 408576698