Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc

Issue 2364473005: Hooking up target audio bitrate to audio network adaptor. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
index aee41da1b0b5c0523bf853ba483964a5ae488281..178d39ce7dc7470cf0ba355ce72997d6b4557de8 100644
--- a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
@@ -106,10 +106,11 @@ TEST(AudioNetworkAdaptorImplTest,
constexpr int kBandwidth = 16000;
constexpr float kPacketLoss = 0.7f;
+ constexpr int kRtt = 100;
+ constexpr int kTargetAudioBitrate = 15000;
Controller::NetworkMetrics check;
check.uplink_bandwidth_bps = rtc::Optional<int>(kBandwidth);
-
for (auto& mock_controller : states.mock_controllers) {
EXPECT_CALL(*mock_controller, MakeDecision(NetworkMetricsIs(check), _));
}
@@ -122,6 +123,20 @@ TEST(AudioNetworkAdaptorImplTest,
}
states.audio_network_adaptor->SetUplinkPacketLossFraction(kPacketLoss);
states.audio_network_adaptor->GetEncoderRuntimeConfig();
+
+ check.rtt_ms = rtc::Optional<int>(kRtt);
+ for (auto& mock_controller : states.mock_controllers) {
+ EXPECT_CALL(*mock_controller, MakeDecision(NetworkMetricsIs(check), _));
+ }
+ states.audio_network_adaptor->SetRtt(kRtt);
+ states.audio_network_adaptor->GetEncoderRuntimeConfig();
+
+ check.target_audio_bitrate_bps = rtc::Optional<int>(kTargetAudioBitrate);
+ for (auto& mock_controller : states.mock_controllers) {
+ EXPECT_CALL(*mock_controller, MakeDecision(NetworkMetricsIs(check), _));
+ }
+ states.audio_network_adaptor->SetTargetAudioBitrate(kTargetAudioBitrate);
+ states.audio_network_adaptor->GetEncoderRuntimeConfig();
}
TEST(AudioNetworkAdaptorImplTest, SetConstraintsIsCalledOnSetFrameLengthRange) {
@@ -159,6 +174,7 @@ TEST(AudioNetworkAdaptorImplTest,
constexpr int kBandwidth = 16000;
constexpr float kPacketLoss = 0.7f;
constexpr int kRtt = 100;
+ constexpr int kTargetAudioBitrate = 15000;
Controller::NetworkMetrics check;
check.uplink_bandwidth_bps = rtc::Optional<int>(kBandwidth);
@@ -181,6 +197,13 @@ TEST(AudioNetworkAdaptorImplTest,
EXPECT_CALL(*states.mock_debug_dump_writer,
DumpNetworkMetrics(NetworkMetricsIs(check), timestamp_check));
states.audio_network_adaptor->SetRtt(kRtt);
+
+ states.simulated_clock->AdvanceTimeMilliseconds(150);
+ timestamp_check += 150;
+ check.target_audio_bitrate_bps = rtc::Optional<int>(kTargetAudioBitrate);
+ EXPECT_CALL(*states.mock_debug_dump_writer,
+ DumpNetworkMetrics(NetworkMetricsIs(check), timestamp_check));
+ states.audio_network_adaptor->SetTargetAudioBitrate(kTargetAudioBitrate);
}
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698