Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2362263002: Fixes minor issue in AudioDeviceTest.RunPlayoutAndRecordingInFullDuplex for iOS (Closed)

Created:
4 years, 2 months ago by henrika_webrtc
Modified:
4 years, 2 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixes minor issue in AudioDeviceTest.RunPlayoutAndRecordingInFullDuplex for iOS. Followup on https://codereview.webrtc.org/2349263004/ BUG=NONE NOTRY=TRUE Committed: https://crrev.com/dda366611e4f5d1b1041bf9087ea7a29763f5f1e Cr-Commit-Position: refs/heads/master@{#14374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
henrika_webrtc
Minor change was required in one of the tests in modules_unittests after another modification referenced ...
4 years, 2 months ago (2016-09-23 14:54:09 UTC) #3
kthelgason
On 2016/09/23 14:54:09, henrika_webrtc wrote: > Minor change was required in one of the tests ...
4 years, 2 months ago (2016-09-23 15:29:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2362263002/1
4 years, 2 months ago (2016-09-23 15:34:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-23 15:42:48 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 15:42:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dda366611e4f5d1b1041bf9087ea7a29763f5f1e
Cr-Commit-Position: refs/heads/master@{#14374}

Powered by Google App Engine
This is Rietveld 408576698