Ensures that ADM for Android and iOS uses identical states when stopping audio

Ensures that ADM for Android and iOS uses identical states when stopping audio

BUG=b/25975010
TBR=tkchin
NOTRY=TRUE

Committed: https://crrev.com/17802ae258e4eecef0ae9825b7962c9bd179ea6c
Cr-Commit-Position: refs/heads/master@{#14328}

[henrika_webrtc, 2016-09-20 12:23:59]

Description was changed from

==========
Ensures that ADM for Android and iOS uses identical states when stopping audio

BUG=
==========

to

==========
Ensures that ADM for Android and iOS uses identical states when stopping audio

BUG=b/25975010
==========

[henrika_webrtc, 2016-09-20 12:23:59]

henrika@webrtc.org changed reviewers:
+ sophiechang@chromium.org, tkchin@webrtc.org

[henrika_webrtc, 2016-09-20 12:26:01]

Following the example on Android also for iOS to ensure that we stop media using
identical members/states to avoid any issues or differences.

[henrika_webrtc, 2016-09-20 12:34:38]

Please press the button if/when OK. Thanks.

[henrika_webrtc, 2016-09-20 12:34:40]

Please press the button if/when OK. Thanks.

[henrika_webrtc, 2016-09-20 14:40:08]

Sophie: feel free to propose changes in this CL. Thanks.

[sophiechang-webrtc, 2016-09-21 10:43:54]

https://codereview.webrtc.org/2349263004/diff/1/webrtc/modules/audio_device/i...
File webrtc/modules/audio_device/ios/audio_device_ios.mm (right):

https://codereview.webrtc.org/2349263004/diff/1/webrtc/modules/audio_device/i...
webrtc/modules/audio_device/ios/audio_device_ios.mm:220: if
(!play_is_initialized_ || !playing_) {
as mentioned offline, i think it would be good to merge the rec_is_initialized_
and play_is_initialized_ to some sort of audio_is_initialized_ variable since
they both just control the audio unit. and also only set audio_is_initialized_
to false when you call ShutdownPlayOrRecord so stick it into that if block in
line 223 and the same thing around StopRecording.

[henrika_webrtc, 2016-09-21 10:55:19]

Thanks for testing and the feedback. Let me run some tests first but it does
sound like a really good idea
given the common usage of the audio unit on iOS.

[henrika_webrtc, 2016-09-21 11:40:38]

PTAL Sophie

[sophiechang-webrtc, 2016-09-21 11:41:33]

lgtm

looks good. thanks!

[henrika_webrtc, 2016-09-21 11:46:16]

Description was changed from

==========
Ensures that ADM for Android and iOS uses identical states when stopping audio

BUG=b/25975010
==========

to

==========
Ensures that ADM for Android and iOS uses identical states when stopping audio

BUG=b/25975010
TBR=tkchin
==========

[henrika_webrtc, 2016-09-21 11:47:16]

Description was changed from

==========
Ensures that ADM for Android and iOS uses identical states when stopping audio

BUG=b/25975010
TBR=tkchin
==========

to

==========
Ensures that ADM for Android and iOS uses identical states when stopping audio

BUG=b/25975010
TBR=tkchin
NOTRY=TRUE
==========

[henrika_webrtc, 2016-09-21 11:47:22]

The CQ bit was checked by henrika@webrtc.org

[commit-bot: I haz the power, 2016-09-21 11:47:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-21 11:55:06]

Description was changed from

==========
Ensures that ADM for Android and iOS uses identical states when stopping audio

BUG=b/25975010
TBR=tkchin
NOTRY=TRUE
==========

to

==========
Ensures that ADM for Android and iOS uses identical states when stopping audio

BUG=b/25975010
TBR=tkchin
NOTRY=TRUE
==========

[commit-bot: I haz the power, 2016-09-21 11:55:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 11:55:19]

Description was changed from

==========
Ensures that ADM for Android and iOS uses identical states when stopping audio

BUG=b/25975010
TBR=tkchin
NOTRY=TRUE
==========

to

==========
Ensures that ADM for Android and iOS uses identical states when stopping audio

BUG=b/25975010
TBR=tkchin
NOTRY=TRUE

Committed: https://crrev.com/17802ae258e4eecef0ae9825b7962c9bd179ea6c
Cr-Commit-Position: refs/heads/master@{#14328}
==========

[commit-bot: I haz the power, 2016-09-21 11:55:20]

Patchset 2 (id:??) landed as
https://crrev.com/17802ae258e4eecef0ae9825b7962c9bd179ea6c
Cr-Commit-Position: refs/heads/master@{#14328}

[tkchin_webrtc, 2016-09-21 15:55:31]

lgtm