Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: webrtc/media/base/videobroadcaster.cc

Issue 2361803003: Add logging statements to places where the frame might be dropped in WebRTC pipeline. (Closed)
Patch Set: Add logging for too many incoming frames stored in VideoRenderFrames. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/base/videobroadcaster.cc
diff --git a/webrtc/media/base/videobroadcaster.cc b/webrtc/media/base/videobroadcaster.cc
index d3bc7a09cebccdcfccb839cda8e1dcd6d8aeadb7..4276984494ae224f454e7ef9b7da7c9f1ee94b62 100644
--- a/webrtc/media/base/videobroadcaster.cc
+++ b/webrtc/media/base/videobroadcaster.cc
@@ -51,6 +51,9 @@ VideoSinkWants VideoBroadcaster::wants() const {
void VideoBroadcaster::OnFrame(const cricket::VideoFrame& frame) {
rtc::CritScope cs(&sinks_and_wants_lock_);
+ if (sink_pairs().empty())
+ LOG(LS_INFO) << "Dropping frame because there are no sink pairs in video "
perkj_webrtc 2016/09/26 06:46:34 This may soon start spitting out logs in chrome th
sakal 2016/09/26 11:23:59 I changed it to log VideoBroadcaster creation and
magjed_webrtc 2016/09/27 15:06:11 It's probably good to have logs for VideoBroadcast
+ "broadcaster.";
for (auto& sink_pair : sink_pairs()) {
if (sink_pair.wants.rotation_applied &&
frame.rotation() != webrtc::kVideoRotation_0) {

Powered by Google App Engine
This is Rietveld 408576698