webrtc/modules/video_coding/generic_decoder.cc - Issue 2361803003: Add logging statements to places where the frame might be dropped in WebRTC pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/generic_decoder.cc

Issue 2361803003: Add logging statements to places where the frame might be dropped in WebRTC pipeline. (Closed)

Patch Set: Add logging for too many incoming frames stored in VideoRenderFrames. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/generic_decoder.cc

diff --git a/webrtc/modules/video_coding/generic_decoder.cc b/webrtc/modules/video_coding/generic_decoder.cc

index 38bdb69245028a3ca2e4f8513bc49ff4b245df25..6756be5056e19bf301476c609cdc7583d158367e 100644

--- a/webrtc/modules/video_coding/generic_decoder.cc

+++ b/webrtc/modules/video_coding/generic_decoder.cc

@@ -77,6 +77,8 @@ int32_t VCMDecodedFrameCallback::Decoded(VideoFrame& decodedImage,

decodedImage.set_render_time_ms(frameInfo->renderTimeMs);

decodedImage.set_rotation(frameInfo->rotation);

callback->FrameToRender(decodedImage);

+ } else {

+ LOG(LS_INFO) << "Dropping frame because callback is NULL.";

}

return WEBRTC_VIDEO_CODEC_OK;

}