Default constructor for file

Default constructor for file

BUG=webrtc:6177
R=perkj@webrtc.org, sprang@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/1d477ea6d5221c6654db4c0a7cebc68bb70aa080

[palmkvist, 2016-09-23 09:33:34]

palmkvist@webrtc.org changed reviewers:
+ perkj@webrtc.org, sprang@webrtc.org

[sprang_webrtc, 2016-09-23 11:26:34]

lgtm
perkj@ ptal

[perkj_webrtc, 2016-09-26 06:43:30]

please create a tracking bug for this work.
Also- can you add a unit tests for this ctor?

https://codereview.webrtc.org/2360303004/diff/1/webrtc/base/file.h
File webrtc/base/file.h (right):

https://codereview.webrtc.org/2360303004/diff/1/webrtc/base/file.h#newcode34
webrtc/base/file.h:34: File();
nit: keep the declaration order. Please move the ~ not beneath the last ctor.

[palmkvist, 2016-09-28 08:51:59]

Description was changed from

==========
Default constructor for file

BUG=
==========

to

==========
Default constructor for file

BUG=webrtc:6177
==========

[perkj_webrtc, 2016-09-28 14:53:35]

lgtm if the below are addressed.

https://codereview.webrtc.org/2360303004/diff/1/webrtc/base/file.h
File webrtc/base/file.h (right):

https://codereview.webrtc.org/2360303004/diff/1/webrtc/base/file.h#newcode34
webrtc/base/file.h:34: File();
On 2016/09/26 06:43:29, perkj_webrtc wrote:
> nit: keep the declaration order. Please move the ~ not beneath the last ctor.

What the heck am I writing... 
I meant- move the ~File beneath the last ctor.

https://codereview.webrtc.org/2360303004/diff/20001/webrtc/base/file.cc
File webrtc/base/file.cc (right):

https://codereview.webrtc.org/2360303004/diff/20001/webrtc/base/file.cc#newco...
webrtc/base/file.cc:17: File::~File() {
dito- move ~File() after the last ctor.

https://codereview.webrtc.org/2360303004/diff/20001/webrtc/base/file.h
File webrtc/base/file.h (right):

https://codereview.webrtc.org/2360303004/diff/20001/webrtc/base/file.h#newcode32
webrtc/base/file.h:32: explicit File(PlatformFile);
this is also ctor - Move ~File after all ctors.

[palmkvist, 2016-10-03 08:59:53]

The CQ bit was checked by palmkvist@webrtc.org

[palmkvist, 2016-10-03 08:59:53]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org,
perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2360303004/#ps40001 (title:
"Nit")

[commit-bot: I haz the power, 2016-10-03 09:00:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-03 11:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 11:00:45]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[commit-bot: I haz the power, 2016-10-03 11:16:17]

Description was changed from

==========
Default constructor for file

BUG=webrtc:6177
==========

to

==========
Default constructor for file

BUG=webrtc:6177
R=perkj@webrtc.org, sprang@webrtc.org

Committed: https://crrev.com/1d477ea6d5221c6654db4c0a7cebc68bb70aa080
Cr-Commit-Position: refs/heads/master@{#14473}
==========

[commit-bot: I haz the power, 2016-10-03 11:16:18]

Patchset 3 (id:??) landed as
https://crrev.com/1d477ea6d5221c6654db4c0a7cebc68bb70aa080
Cr-Commit-Position: refs/heads/master@{#14473}

[palmkvist, 2016-10-03 11:16:19]

Description was changed from

==========
Default constructor for file

BUG=webrtc:6177
R=perkj@webrtc.org, sprang@webrtc.org

Committed: https://crrev.com/1d477ea6d5221c6654db4c0a7cebc68bb70aa080
Cr-Commit-Position: refs/heads/master@{#14473}
==========

to

==========
Default constructor for file

BUG=webrtc:6177
R=perkj@webrtc.org, sprang@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/1d477ea6d5221c6654db4c0a7...
==========

[palmkvist, 2016-10-03 11:16:21]

Committed patchset #3 (id:40001) manually as
1d477ea6d5221c6654db4c0a7cebc68bb70aa080 (presubmit successful).