Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Unified Diff: webrtc/base/file_unittest.cc

Issue 2360303004: Default constructor for file (Closed)
Patch Set: Nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/file.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/file_unittest.cc
diff --git a/webrtc/base/file_unittest.cc b/webrtc/base/file_unittest.cc
index edf2b29127a5ede58a160afb94efcde5a36d9a5a..aa787c14c59138d478f88295909d284133241f81 100644
--- a/webrtc/base/file_unittest.cc
+++ b/webrtc/base/file_unittest.cc
@@ -56,12 +56,24 @@ class FileTest : public ::testing::Test {
path_ = webrtc::test::TempFilename(webrtc::test::OutputPath(), "test_file");
ASSERT_FALSE(path_.empty());
}
- rtc::File OpenTempFile() { return rtc::File::Open(path_); }
- void TearDown() { rtc::RemoveFile(path_); }
+ void TearDown() { RemoveFile(path_); }
};
+TEST_F(FileTest, DefaultConstructor) {
+ File file;
+ uint8_t buffer[10] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
+
+ EXPECT_FALSE(file.IsOpen());
+ EXPECT_EQ(0u, file.Write(buffer, 10));
+ EXPECT_FALSE(file.Seek(0));
+ EXPECT_EQ(0u, file.Read(buffer, 10));
+ EXPECT_EQ(0u, file.WriteAt(buffer, 10, 0));
+ EXPECT_EQ(0u, file.ReadAt(buffer, 10, 0));
+ EXPECT_FALSE(file.Close());
+}
+
TEST_F(FileTest, DoubleClose) {
- File file = OpenTempFile();
+ File file = File::Open(path_);
ASSERT_TRUE(file.IsOpen()) << "Error: " << LastError();
EXPECT_TRUE(file.Close());
@@ -69,7 +81,7 @@ TEST_F(FileTest, DoubleClose) {
}
TEST_F(FileTest, SimpleReadWrite) {
- File file = OpenTempFile();
+ File file = File::Open(path_);
ASSERT_TRUE(file.IsOpen()) << "Error: " << LastError();
uint8_t data[100] = {0};
@@ -101,7 +113,7 @@ TEST_F(FileTest, SimpleReadWrite) {
}
TEST_F(FileTest, ReadWriteClose) {
- File file = OpenTempFile();
+ File file = File::Open(path_);
ASSERT_TRUE(file.IsOpen()) << "Error: " << LastError();
uint8_t data[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
@@ -109,14 +121,14 @@ TEST_F(FileTest, ReadWriteClose) {
EXPECT_EQ(10u, file.Write(data, 10));
EXPECT_TRUE(file.Close());
- File file2 = OpenTempFile();
+ File file2 = File::Open(path_);
ASSERT_TRUE(file2.IsOpen()) << "Error: " << LastError();
EXPECT_EQ(10u, file2.Read(out, 10));
EXPECT_TRUE(VerifyBuffer(out, 10, 0));
}
TEST_F(FileTest, RandomAccessRead) {
- File file = OpenTempFile();
+ File file = File::Open(path_);
ASSERT_TRUE(file.IsOpen()) << "Error: " << LastError();
uint8_t data[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
@@ -134,7 +146,7 @@ TEST_F(FileTest, RandomAccessRead) {
}
TEST_F(FileTest, RandomAccessReadWrite) {
- File file = OpenTempFile();
+ File file = File::Open(path_);
ASSERT_TRUE(file.IsOpen()) << "Error: " << LastError();
uint8_t data[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
« no previous file with comments | « webrtc/base/file.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698