webrtc/base/httpcommon.cc - Issue 2358993004: Enable the -Wundef warning for clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/httpcommon.cc

Issue 2358993004: Enable the -Wundef warning for clang (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/httpcommon.cc

diff --git a/webrtc/base/httpcommon.cc b/webrtc/base/httpcommon.cc

index c90bea51ccaa8510b5925548de5af2cdb4e8ace8..7bc18c4ad9e97daa4d4d232f1336c14d550d8414 100644

--- a/webrtc/base/httpcommon.cc

+++ b/webrtc/base/httpcommon.cc

@@ -388,7 +388,7 @@ bool HttpDateToSeconds(const std::string& date, time_t* seconds) {

tm *tm_for_timezone = localtime(&gmt);

*seconds = gmt + tm_for_timezone->tm_gmtoff;

#else

-#if _MSC_VER >= 1900

+#if defined(_MSC_VER) && _MSC_VER >= 1900

long timezone = 0;

_get_timezone(&timezone);

#endif

« no previous file with comments | « webrtc/base/httpclient.h ('k') | webrtc/base/ignore_wundef.h » ('j') | no next file with comments »