Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: webrtc/base/httpcommon.cc

Issue 2358993004: Enable the -Wundef warning for clang (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/httpclient.h ('k') | webrtc/base/ignore_wundef.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 370 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 if (!find_string(zindex, zone, kTimeZones, arraysize(kTimeZones))) { 381 if (!find_string(zindex, zone, kTimeZones, arraysize(kTimeZones))) {
382 return false; 382 return false;
383 } 383 }
384 gmt = non_gmt + kTimeZoneOffsets[zindex] * 60 * 60; 384 gmt = non_gmt + kTimeZoneOffsets[zindex] * 60 * 60;
385 } 385 }
386 // TODO: Android should support timezone, see b/2441195 386 // TODO: Android should support timezone, see b/2441195
387 #if defined(WEBRTC_MAC) && !defined(WEBRTC_IOS) || defined(WEBRTC_ANDROID) || de fined(BSD) 387 #if defined(WEBRTC_MAC) && !defined(WEBRTC_IOS) || defined(WEBRTC_ANDROID) || de fined(BSD)
388 tm *tm_for_timezone = localtime(&gmt); 388 tm *tm_for_timezone = localtime(&gmt);
389 *seconds = gmt + tm_for_timezone->tm_gmtoff; 389 *seconds = gmt + tm_for_timezone->tm_gmtoff;
390 #else 390 #else
391 #if _MSC_VER >= 1900 391 #if defined(_MSC_VER) && _MSC_VER >= 1900
392 long timezone = 0; 392 long timezone = 0;
393 _get_timezone(&timezone); 393 _get_timezone(&timezone);
394 #endif 394 #endif
395 *seconds = gmt - timezone; 395 *seconds = gmt - timezone;
396 #endif 396 #endif
397 return true; 397 return true;
398 } 398 }
399 399
400 std::string HttpAddress(const SocketAddress& address, bool secure) { 400 std::string HttpAddress(const SocketAddress& address, bool secure) {
401 return (address.port() == HttpDefaultPort(secure)) 401 return (address.port() == HttpDefaultPort(secure))
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
1046 } 1046 }
1047 #endif 1047 #endif
1048 #endif // WEBRTC_WIN 1048 #endif // WEBRTC_WIN
1049 1049
1050 return HAR_IGNORE; 1050 return HAR_IGNORE;
1051 } 1051 }
1052 1052
1053 ////////////////////////////////////////////////////////////////////// 1053 //////////////////////////////////////////////////////////////////////
1054 1054
1055 } // namespace rtc 1055 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/httpclient.h ('k') | webrtc/base/ignore_wundef.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698