Fix a stun attribute leak.

Fix a stun attribute leak.

In https://cs.chromium.org/chromium/src/third_party/webrtc/p2p/base/stun.cc?rcl=1474384719&l=352,
if read returned false, the created attr would not be released.

BUG=chromium:648064
R=skvlad@webrtc.org

Committed: https://crrev.com/3e02430587370ba7e02cd6eec4970fdd6e1ea2c2
Cr-Commit-Position: refs/heads/master@{#14357}

[skvlad, 2016-09-20 23:14:20]

skvlad@webrtc.org changed reviewers:
+ skvlad@webrtc.org

[skvlad, 2016-09-20 23:14:21]

lgtm

https://codereview.webrtc.org/2357733002/diff/1/webrtc/p2p/base/stun.cc
File webrtc/p2p/base/stun.cc (right):

https://codereview.webrtc.org/2357733002/diff/1/webrtc/p2p/base/stun.cc#newco...
webrtc/p2p/base/stun.cc:344: CreateAttribute(attr_type, attr_length));
You could also change CreateAttribute itself to return a unique_ptr, but this
doesn't really matter a lot.

attrs_ could also be a vector of unique_ptrs - which would make the destructor
simpler.

Either way is good.

[honghaiz3, 2016-09-21 17:36:31]

https://codereview.webrtc.org/2357733002/diff/1/webrtc/p2p/base/stun.cc
File webrtc/p2p/base/stun.cc (right):

https://codereview.webrtc.org/2357733002/diff/1/webrtc/p2p/base/stun.cc#newco...
webrtc/p2p/base/stun.cc:344: CreateAttribute(attr_type, attr_length));
On 2016/09/20 23:14:21, skvlad wrote:
> You could also change CreateAttribute itself to return a unique_ptr, but this
> doesn't really matter a lot.
> 
> attrs_ could also be a vector of unique_ptrs - which would make the destructor
> simpler.
> 
> Either way is good.
I will leave the improvement to a future CL. Add a TODO.

[honghaiz3, 2016-09-21 17:36:50]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-09-21 17:36:50]

The patchset sent to the CQ was uploaded after l-g-t-m from skvlad@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2357733002/#ps20001 (title:
".")

[commit-bot: I haz the power, 2016-09-21 17:36:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-21 19:37:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 19:37:44]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[honghaiz3, 2016-09-22 16:52:34]

Description was changed from

==========
Fix a stun attribute leak.

In
https://cs.chromium.org/chromium/src/third_party/webrtc/p2p/base/stun.cc?rcl=...,
if read returned false, the created attr would not be released.

BUG=chromium:648064
==========

to

==========
Fix a stun attribute leak.

In
https://cs.chromium.org/chromium/src/third_party/webrtc/p2p/base/stun.cc?rcl=...,
if read returned false, the created attr would not be released.

BUG=chromium:648064
R=skvlad@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/3e02430587370ba7e02cd6eec...
==========

[honghaiz3, 2016-09-22 16:52:36]

Committed patchset #2 (id:20001) manually as
3e02430587370ba7e02cd6eec4970fdd6e1ea2c2 (presubmit successful).

[commit-bot: I haz the power, 2016-09-22 16:52:38]

Description was changed from

==========
Fix a stun attribute leak.

In
https://cs.chromium.org/chromium/src/third_party/webrtc/p2p/base/stun.cc?rcl=...,
if read returned false, the created attr would not be released.

BUG=chromium:648064
R=skvlad@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/3e02430587370ba7e02cd6eec...
==========

to

==========
Fix a stun attribute leak.

In
https://cs.chromium.org/chromium/src/third_party/webrtc/p2p/base/stun.cc?rcl=...,
if read returned false, the created attr would not be released.

BUG=chromium:648064
R=skvlad@webrtc.org

Committed: https://crrev.com/3e02430587370ba7e02cd6eec4970fdd6e1ea2c2
Cr-Commit-Position: refs/heads/master@{#14357}
==========