Fix a stun attribute leak.

webrtc/p2p/base/stun.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 322 matching lines @@
   attrs_->resize(0);
 
   size_t rest = buf->Length() - length_;
   while (buf->Length() > rest) {
     uint16_t attr_type, attr_length;
     if (!buf->ReadUInt16(&attr_type))
       return false;
     if (!buf->ReadUInt16(&attr_length))
       return false;
 
-    StunAttribute* attr = CreateAttribute(attr_type, attr_length);
+    std::unique_ptr<StunAttribute> attr(
+        CreateAttribute(attr_type, attr_length));
     if (!attr) {
       // Skip any unknown or malformed attributes.
       if ((attr_length % 4) != 0) {
         attr_length += (4 - (attr_length % 4));
       }
       if (!buf->Consume(attr_length))
         return false;
     } else {
       if (!attr->Read(buf))
         return false;
-      attrs_->push_back(attr);
+      // TODO(honghaiz): Change |attrs_| to be a vector of unique_ptrs.
+      attrs_->push_back(attr.release());
     }
   }
 
   ASSERT(buf->Length() == rest);
   return true;
 }
 
 bool StunMessage::Write(ByteBufferWriter* buf) const {
   buf->WriteUInt16(type_);
   buf->WriteUInt16(length_);
@@ skipping 547 matching lines @@
       digest, sizeof(digest));
   if (size == 0) {
     return false;
   }
 
   *hash = std::string(digest, size);
   return true;
 }
 
 }  // namespace cricket