Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2356073004: Ignores warning for SecRandomCopyBytes() using Xcode 8 (Closed)

Created:
4 years, 3 months ago by henrika_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
tkchin_webrtc, Chuck
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 NOTRY=TRUE TBR=kjellander Committed: https://crrev.com/27d8b610120ab364e1b466ccbfa50cfe36703700 Cr-Commit-Position: refs/heads/master@{#14326}

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 4

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M webrtc/examples/BUILD.gn View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M webrtc/webrtc_examples.gyp View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
henrika_webrtc
Ensures that we can build AppRTCDemo using Xcode 8 which is needed to support iOS ...
4 years, 3 months ago (2016-09-21 10:00:23 UTC) #5
henrika_webrtc
Issue https://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/builds/2761/steps/build/logs/stdio seems unrelated to this CL.
4 years, 3 months ago (2016-09-21 10:10:47 UTC) #6
kjellander_webrtc
You can ignore ios_api_framwork trybot since it's currently not enabled in CQ. https://codereview.webrtc.org/2356073004/diff/20001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn ...
4 years, 3 months ago (2016-09-21 10:16:07 UTC) #7
kjellander_webrtc
Also please use NOTRY=True and fewer trybots on a change like this.
4 years, 3 months ago (2016-09-21 10:17:44 UTC) #8
henrika_webrtc
https://codereview.webrtc.org/2356073004/diff/20001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2356073004/diff/20001/webrtc/examples/BUILD.gn#newcode327 webrtc/examples/BUILD.gn:327: # Enabled for cflags_objc in build/config/compiler/BUILD.gn. On 2016/09/21 10:16:07, ...
4 years, 3 months ago (2016-09-21 10:48:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2356073004/40001
4 years, 3 months ago (2016-09-21 11:02:16 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-21 11:02:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2356073004/40001
4 years, 3 months ago (2016-09-21 11:04:47 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-21 11:13:02 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/27d8b610120ab364e1b466ccbfa50cfe36703700 Cr-Commit-Position: refs/heads/master@{#14326}
4 years, 3 months ago (2016-09-21 11:13:12 UTC) #21
kjellander_webrtc
4 years, 3 months ago (2016-09-21 12:10:56 UTC) #22
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698