Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2356073004:
Ignores warning for SecRandomCopyBytes() using Xcode 8 (Closed)
|
Created:
4 years, 3 months ago by henrika_webrtc Modified:
4 years, 3 months ago Reviewers:
kjellander_webrtc CC:
tkchin_webrtc, Chuck Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionIgnores warning for SecRandomCopyBytes() using Xcode 8
BUG=webrtc:6396
NOTRY=TRUE
TBR=kjellander
Committed: https://crrev.com/27d8b610120ab364e1b466ccbfa50cfe36703700
Cr-Commit-Position: refs/heads/master@{#14326}
Patch Set 1 #Patch Set 2 : nit #
Total comments: 4
Patch Set 3 : nits #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG= ========== to ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=NONE ==========
Description was changed from ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=NONE ========== to ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=6396 ==========
Description was changed from ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=6396 ========== to ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 ==========
henrika@webrtc.org changed reviewers: + kjellander@webrtc.org
Ensures that we can build AppRTCDemo using Xcode 8 which is needed to support iOS 10.10.
Issue https://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/buil... seems unrelated to this CL.
You can ignore ios_api_framwork trybot since it's currently not enabled in CQ. https://codereview.webrtc.org/2356073004/diff/20001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2356073004/diff/20001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:327: # Enabled for cflags_objc in build/config/compiler/BUILD.gn. Move this comment down since it only applies to line 329. https://codereview.webrtc.org/2356073004/diff/20001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:331: # Hide the warning for SecRandomCopyBytes(), till we update to upstream. till -> until
Also please use NOTRY=True and fewer trybots on a change like this.
https://codereview.webrtc.org/2356073004/diff/20001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2356073004/diff/20001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:327: # Enabled for cflags_objc in build/config/compiler/BUILD.gn. On 2016/09/21 10:16:07, kjellander_webrtc wrote: > Move this comment down since it only applies to line 329. Done. https://codereview.webrtc.org/2356073004/diff/20001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:331: # Hide the warning for SecRandomCopyBytes(), till we update to upstream. On 2016/09/21 10:16:07, kjellander_webrtc wrote: > till -> until Done.
Description was changed from ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 ========== to ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 NOTRY=TRUE ==========
The CQ bit was checked by henrika@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 NOTRY=TRUE ========== to ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 NOTRY=TRUE TBR=kjellander ==========
The CQ bit was checked by henrika@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 NOTRY=TRUE TBR=kjellander ========== to ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 NOTRY=TRUE TBR=kjellander ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 NOTRY=TRUE TBR=kjellander ========== to ========== Ignores warning for SecRandomCopyBytes() using Xcode 8 BUG=webrtc:6396 NOTRY=TRUE TBR=kjellander Committed: https://crrev.com/27d8b610120ab364e1b466ccbfa50cfe36703700 Cr-Commit-Position: refs/heads/master@{#14326} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/27d8b610120ab364e1b466ccbfa50cfe36703700 Cr-Commit-Position: refs/heads/master@{#14326}
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
