Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2352623002: AcmReceiver::DecoderByPayloadType: Ask NetEq for decoder (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AcmReceiver::DecoderByPayloadType: Ask NetEq for decoder Instead of looking in AcmReceiver::decoders_, which we're trying to get rid of. (This is a re-land of https://codereview.webrtc.org/2341283002.) BUG=webrtc:5801 Committed: https://crrev.com/d120192f320ef6ab0c52a0680b29bf8b73eec005 Cr-Commit-Position: refs/heads/master@{#14312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver_unittest_oldapi.cc View 4 chunks +10 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
hlundin-webrtc
lgtm
4 years, 3 months ago (2016-09-19 11:49:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2352623002/1
4 years, 3 months ago (2016-09-20 12:14:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-20 14:15:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2352623002/1
4 years, 3 months ago (2016-09-20 20:56:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 22:18:27 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 22:18:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d120192f320ef6ab0c52a0680b29bf8b73eec005
Cr-Commit-Position: refs/heads/master@{#14312}

Powered by Google App Engine
This is Rietveld 408576698