Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2348083003: Make android_junit_tests use LocalRobolectricTestRunner (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make android_junit_tests use LocalRobolectricTestRunner This was originally fixed in https://codereview.webrtc.org/2346793002 but that CL was reverted. In the reland (https://codereview.webrtc.org/2348663003) only the GN change was included, not the code change. BUG=webrtc:6365 NOTRY=True TBR=sakal@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/da96288904bfddabb383bf9862233f0b1a34a494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/androidjunit/src/org/webrtc/CameraEnumerationTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
4 years, 3 months ago (2016-09-18 19:27:26 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/da96288904bfddabb383bf9862233f0b1a34a494 Cr-Commit-Position: refs/heads/master@{#14281}
4 years, 3 months ago (2016-09-18 19:28:20 UTC) #4
kjellander_webrtc
Committed patchset #1 (id:1) manually as da96288904bfddabb383bf9862233f0b1a34a494 (presubmit successful).
4 years, 3 months ago (2016-09-18 19:28:21 UTC) #5
sakal
4 years, 3 months ago (2016-09-19 07:14:45 UTC) #6
Message was sent while issue was closed.
Oops. lgtm

Powered by Google App Engine
This is Rietveld 408576698