Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2346793002: Fix android_junit_tests and add a GN target for them. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix android_junit_tests and add a GN target for them. BUG=webrtc:6365 NOTRY=True Committed: https://crrev.com/bb716daea73889517f996aa29f867563ed63d58a Cr-Commit-Position: refs/heads/master@{#14241}

Patch Set 1 : Remove unrelated change. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M webrtc/BUILD.gn View 2 chunks +15 lines, -0 lines 1 comment Download
M webrtc/androidjunit/src/org/webrtc/CameraEnumerationTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
sakal
PTAL
4 years, 3 months ago (2016-09-15 11:45:45 UTC) #5
kjellander_webrtc
lgtm
4 years, 3 months ago (2016-09-15 11:59:17 UTC) #6
magjed_webrtc
lgtm
4 years, 3 months ago (2016-09-15 13:20:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2346793002/20001
4 years, 3 months ago (2016-09-15 13:20:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2346793002/20001
4 years, 3 months ago (2016-09-15 19:26:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-15 19:27:56 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bb716daea73889517f996aa29f867563ed63d58a Cr-Commit-Position: refs/heads/master@{#14241}
4 years, 3 months ago (2016-09-15 19:28:06 UTC) #16
henrika_webrtc
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.webrtc.org/2341213003/ by henrika@webrtc.org. ...
4 years, 3 months ago (2016-09-16 11:11:40 UTC) #17
kjellander_webrtc
4 years, 3 months ago (2016-09-16 11:13:34 UTC) #18
Message was sent while issue was closed.
Found the problem...

https://codereview.webrtc.org/2346793002/diff/20001/webrtc/BUILD.gn
File webrtc/BUILD.gn (right):

https://codereview.webrtc.org/2346793002/diff/20001/webrtc/BUILD.gn#newcode840
webrtc/BUILD.gn:840: if (is_android) {
Just put this into
if (rtc_include_tests) {

instead and it will not affect Chrome.

Powered by Google App Engine
This is Rietveld 408576698