Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: webrtc/base/platform_file.h

Issue 2347473003: Removing, opening and creating files in platform_file and file (Closed)
Patch Set: Remove some unnecessary headers Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/file_win.cc ('k') | webrtc/base/platform_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/platform_file.h
diff --git a/webrtc/base/platform_file.h b/webrtc/base/platform_file.h
index 12e08e9acc2d278ab2474f4144be4244f402f6ee..3bd1b1c035a2168916f451e609670cd186c3a668 100644
--- a/webrtc/base/platform_file.h
+++ b/webrtc/base/platform_file.h
@@ -13,8 +13,10 @@
#include <stdio.h>
perkj_webrtc 2016/09/15 13:35:30 nit: remove extra line after stdio.h
+#include <string>
+
#if defined(WEBRTC_WIN)
-#include <windows.h>
+#include "webrtc/base/win32.h"
#endif
namespace rtc {
@@ -39,6 +41,19 @@ FILE* FdopenPlatformFileForWriting(PlatformFile file);
// Use fclose instead.
bool ClosePlatformFile(PlatformFile file);
+// Removes a file in the filesystem.
+bool RemoveFile(const std::string& path);
+
+// Opens a file for reading and writing. You might want to use base/file.h
+// instead, this function is largely used for tests that require exactly a
perkj_webrtc 2016/09/15 13:35:30 dito as comment below.
+// PlatformFile.
+PlatformFile OpenPlatformFile(const std::string& path);
+
+// Creates a new file for reading and writing. If the file already exists it
+// will be overwritten. You might want to use base/file.h instead, this
perkj_webrtc 2016/09/15 13:35:30 instead. Suggest you remove the sentence about ho
+// function is largely used for tests that require exactly a PlatformFile.
+PlatformFile CreatePlatformFile(const std::string& path);
+
} // namespace rtc
#endif // WEBRTC_BASE_PLATFORM_FILE_H_
« no previous file with comments | « webrtc/base/file_win.cc ('k') | webrtc/base/platform_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698