Removing, opening and creating files in platform_file and file

webrtc/base/platform_file.h

 /*
  *  Copyright 2014 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_BASE_PLATFORM_FILE_H_
 #define WEBRTC_BASE_PLATFORM_FILE_H_
 
 #include <stdio.h>
 

[perkj_webrtc, 2016/09/15 13:35:30]

nit: remove extra line after stdio.h

+#include <string>
+
 #if defined(WEBRTC_WIN)
-#include <windows.h>
+#include "webrtc/base/win32.h"
 #endif
 
 namespace rtc {
 
 #if defined(WEBRTC_WIN)
 typedef HANDLE PlatformFile;
 #elif defined(WEBRTC_POSIX)
 typedef int PlatformFile;
 #else
 #error Unsupported platform
 #endif
 
 extern const PlatformFile kInvalidPlatformFileValue;
 
 // Associates a standard FILE stream with an existing PlatformFile.
 // Note that after this function has returned a valid FILE stream,
 // the PlatformFile should no longer be used.
 FILE* FdopenPlatformFileForWriting(PlatformFile file);
 
 // Closes a PlatformFile.
 // Don't use ClosePlatformFile to close a file opened with FdopenPlatformFile.
 // Use fclose instead.
 bool ClosePlatformFile(PlatformFile file);
 
+// Removes a file in the filesystem.
+bool RemoveFile(const std::string& path);
+
+// Opens a file for reading and writing. You might want to use base/file.h
+// instead, this function is largely used for tests that require exactly a

[perkj_webrtc, 2016/09/15 13:35:30]

dito as comment below.

+// PlatformFile.
+PlatformFile OpenPlatformFile(const std::string& path);
+
+// Creates a new file for reading and writing. If the file already exists it
+// will be overwritten. You might want to use base/file.h instead, this

[perkj_webrtc, 2016/09/15 13:35:30]

instead. 
Suggest you remove the sentence about how this is used since it might change in
the future.

+// function is largely used for tests that require exactly a PlatformFile.
+PlatformFile CreatePlatformFile(const std::string& path);
+
 }  // namespace rtc
 
 #endif  // WEBRTC_BASE_PLATFORM_FILE_H_