Removing, opening and creating files in platform_file and file

Removing, opening and creating files in platform_file and file

BUG=
R=perkj@webrtc.org, sprang@google.com

Committed: https://crrev.com/971eb27e54ff43302732b456722dae9a38145c14
Cr-Commit-Position: refs/heads/master@{#14250}

[palmkvist, 2016-09-15 11:33:12]

palmkvist@webrtc.org changed reviewers:
+ perkj@webrtc.org, sprang@google.com

[palmkvist, 2016-09-15 11:33:13]

Makes some common file related activities available in base, to prevent
reimplementation in every test that needs it.

[sprang, 2016-09-15 11:59:06]

lgtm
perkj ptal as owner

[perkj_webrtc, 2016-09-15 13:35:30]

lgtm with comments addressed.

https://codereview.webrtc.org/2347473003/diff/20001/webrtc/base/platform_file.h
File webrtc/base/platform_file.h (right):

https://codereview.webrtc.org/2347473003/diff/20001/webrtc/base/platform_file...
webrtc/base/platform_file.h:15: 
nit: remove extra line after stdio.h

https://codereview.webrtc.org/2347473003/diff/20001/webrtc/base/platform_file...
webrtc/base/platform_file.h:48: // instead, this function is largely used for
tests that require exactly a
dito as comment below.

https://codereview.webrtc.org/2347473003/diff/20001/webrtc/base/platform_file...
webrtc/base/platform_file.h:53: // will be overwritten. You might want to use
base/file.h instead, this
instead. 
Suggest you remove the sentence about how this is used since it might change in
the future.

[palmkvist, 2016-09-15 14:04:37]

The CQ bit was checked by palmkvist@webrtc.org

[palmkvist, 2016-09-15 14:04:38]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@google.com,
perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2347473003/#ps40001 (title:
"Comments")

[commit-bot: I haz the power, 2016-09-15 14:04:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-15 16:05:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 16:05:17]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[palmkvist, 2016-09-16 08:19:37]

Description was changed from

==========
Removing, opening and creating files in platform_file and file

BUG=
==========

to

==========
Removing, opening and creating files in platform_file and file

BUG=
R=perkj@webrtc.org, sprang@google.com

Committed:
https://chromium.googlesource.com/external/webrtc/+/971eb27e54ff43302732b4567...
==========

[palmkvist, 2016-09-16 08:19:38]

Committed patchset #3 (id:40001) manually as
971eb27e54ff43302732b456722dae9a38145c14 (presubmit successful).

[commit-bot: I haz the power, 2016-09-16 08:19:41]

Description was changed from

==========
Removing, opening and creating files in platform_file and file

BUG=
R=perkj@webrtc.org, sprang@google.com

Committed:
https://chromium.googlesource.com/external/webrtc/+/971eb27e54ff43302732b4567...
==========

to

==========
Removing, opening and creating files in platform_file and file

BUG=
R=perkj@webrtc.org, sprang@google.com

Committed: https://crrev.com/971eb27e54ff43302732b456722dae9a38145c14
Cr-Commit-Position: refs/heads/master@{#14250}
==========