Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2341113005: I420BufferPool: Replace SequencedTaskChecker with RaceChecker (Closed)

Created:
4 years, 3 months ago by magjed_webrtc
Modified:
4 years, 3 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

I420BufferPool: Replace SequencedTaskChecker with RaceChecker SequencedTaskChecker does not work with the iOS dispatch queue. See bug for more info. BUG=webrtc:6367 R=perkj@webrtc.org Committed: https://crrev.com/7fd92866c35a4060fd2346a15c73019f50df2bf1 Cr-Commit-Position: refs/heads/master@{#14272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M webrtc/common_video/i420_buffer_pool.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/common_video/include/i420_buffer_pool.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
magjed_webrtc
perkj - please take a look.
4 years, 3 months ago (2016-09-16 12:40:03 UTC) #3
perkj_webrtc
lgtm
4 years, 3 months ago (2016-09-16 14:46:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2341113005/1
4 years, 3 months ago (2016-09-16 14:46:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-16 16:46:44 UTC) #8
magjed_webrtc
4 years, 3 months ago (2016-09-17 09:27:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7fd92866c35a4060fd2346a15c73019f50df2bf1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698