Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2341113004: Temporarily remove ios_api_framework from the commit queue. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Temporarily remove ios_api_framework from the commit queue. Temporarily remove ios_api_framework until [1] is ported to GN. This script is blocking Chromium rolls [1]: https://cs.chromium.org/chromium/src/third_party/webrtc/build/ios/build_ios_libs.sh?sq=package:chromium&dr=C NOTRY=True TBR=kjellander@webrtc.org BUG=webrtc:6372 Committed: https://crrev.com/3d2ea1d2b363f2f65de0ca12d100040385db856b Cr-Commit-Position: refs/heads/master@{#14266}

Patch Set 1 #

Patch Set 2 : Updated bug link. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M infra/config/cq.cfg View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-09-16 10:58:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2341113004/40001
4 years, 3 months ago (2016-09-16 14:14:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2341113004/40001
4 years, 3 months ago (2016-09-16 14:48:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-16 14:56:34 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3d2ea1d2b363f2f65de0ca12d100040385db856b Cr-Commit-Position: refs/heads/master@{#14266}
4 years, 3 months ago (2016-09-16 14:56:36 UTC) #14
kjellander_webrtc
lgtm
4 years, 3 months ago (2016-09-16 17:10:49 UTC) #15
kjellander_webrtc
4 years, 1 month ago (2016-11-14 07:17:34 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.webrtc.org/2494403002/ by kjellander@webrtc.org.

The reason for reverting is: The commit bot has been green for a while:
https://build.chromium.org/p/client.webrtc/builders/iOS%20API%20Framework%20B....

Powered by Google App Engine
This is Rietveld 408576698