Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: webrtc/test/testsupport/fileutils.h

Issue 2340773002: Assume ProjectRootPath() equals ../.. in Desktop (Closed)
Patch Set: Updated comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/test/testsupport/fileutils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/testsupport/fileutils.h
diff --git a/webrtc/test/testsupport/fileutils.h b/webrtc/test/testsupport/fileutils.h
index 78789fa870908f52b86c0fcc2269cef13b87cfed..482b1874a7f0fd2f8655bef0cbaa1fe1b48b347c 100644
--- a/webrtc/test/testsupport/fileutils.h
+++ b/webrtc/test/testsupport/fileutils.h
@@ -75,10 +75,11 @@ extern const char* kCannotFindProjectRootDir;
// Finds the root dir of the project, to be able to set correct paths to
// resource files used by tests.
-// The implementation is simple: it just looks for the file defined by
-// kProjectRootFileName, starting in the current directory (the working
-// directory) and then steps upward until it is found (or it is at the root of
-// the file system).
+// For desktop, we assume that the project root is two levels above (i.e. the
+// current working directory + /../../)
+// For Android, it is assumed to be /sdcard/chromium_tests_root/
+// For iOS, the resource files are assumed to be included in the test's .app
+// bundle.
// If the current working directory is above the project root dir, it will not
// be found.
//
« no previous file with comments | « no previous file | webrtc/test/testsupport/fileutils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698