Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: webrtc/test/testsupport/fileutils.cc

Issue 2340773002: Assume ProjectRootPath() equals ../.. in Desktop (Closed)
Patch Set: Updated comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/test/testsupport/fileutils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/testsupport/fileutils.cc
diff --git a/webrtc/test/testsupport/fileutils.cc b/webrtc/test/testsupport/fileutils.cc
index 4bf8c5fa19178048ec4edda00e001796962a7a66..ef8e5d5c8d6cc37f56b05bb3f539037e5ac9e80d 100644
--- a/webrtc/test/testsupport/fileutils.cc
+++ b/webrtc/test/testsupport/fileutils.cc
@@ -59,8 +59,6 @@ const char* kPathDelimiter = "/";
#ifdef WEBRTC_ANDROID
const char* kRootDirName = "/sdcard/chromium_tests_root/";
#else
-// The file we're looking for to identify the project root dir.
-const char* kProjectRootFileName = "DEPS";
#if !defined(WEBRTC_IOS)
const char* kOutputDirName = "out";
#endif
@@ -125,21 +123,22 @@ std::string ProjectRootPath() {
if (path == kFallbackPath) {
return kCannotFindProjectRootDir;
}
- if (relative_dir_path_set) {
+ if (relative_dir_path_set && strcmp(relative_dir_path, ".") != 0) {
path = path + kPathDelimiter + relative_dir_path;
}
- // Check for our file that verifies the root dir.
+ // Remove two directory levels from the path, i.e. a path like
+ // /absolute/path/src/out/Debug will become /absolute/path/src/
size_t path_delimiter_index = path.find_last_of(kPathDelimiter);
- while (path_delimiter_index != std::string::npos) {
- std::string root_filename = path + kPathDelimiter + kProjectRootFileName;
- if (FileExists(root_filename)) {
- return path + kPathDelimiter;
- }
+ if (path_delimiter_index != std::string::npos) {
// Move up one directory in the directory tree.
path = path.substr(0, path_delimiter_index);
path_delimiter_index = path.find_last_of(kPathDelimiter);
+ if (path_delimiter_index != std::string::npos) {
+ // Move up another directory in the directory tree. We should now be at
+ // the project root.
+ return path.substr(0, path_delimiter_index) + kPathDelimiter;
+ }
}
- // Reached the root directory.
fprintf(stderr, "Cannot find project root directory!\n");
return kCannotFindProjectRootDir;
}
« no previous file with comments | « webrtc/test/testsupport/fileutils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698