Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2340233003: Reland of Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. (Closed)

Created:
4 years, 3 months ago by Max Morin WebRTC
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. (patchset #1 id:1 of https://codereview.webrtc.org/2340253003/ ) Reason for revert: Fix: let audio_device depend on rtc_base on IOS. Original issue's description: > Revert of Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. (patchset #1 id:1 of https://codereview.webrtc.org/2346763002/ ) > > Reason for revert: > Breaks iOS > > Original issue's description: > > Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. > > > > BUG=webrtc:3806 > > NOTRY=True > > > > Committed: https://crrev.com/100c9d02669910bce06099b3cc1eaad60fd661dd > > Cr-Commit-Position: refs/heads/master@{#14223} > > TBR=kjellander@webrtc.org,henrika@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:3806 > > Committed: https://crrev.com/89fb9201b70616a1c33e277f38bf9367112536e8 > Cr-Commit-Position: refs/heads/master@{#14224} TBR=kjellander@webrtc.org,henrika@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOTRY=true BUG=webrtc:3806 Committed: https://crrev.com/ec62374ccd4aaf1a32bcf3cedb9bfbab6d189c65 Cr-Commit-Position: refs/heads/master@{#14233}

Patch Set 1 #

Patch Set 2 : Add dependency on rtc_base. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M PRESUBMIT.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M webrtc/base/base.gyp View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/audio_device.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Max Morin WebRTC
Created Reland of Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base.
4 years, 3 months ago (2016-09-15 10:46:28 UTC) #1
Max Morin WebRTC
Kjellander: PTAL
4 years, 3 months ago (2016-09-15 11:10:05 UTC) #2
kjellander_webrtc
lgtm
4 years, 3 months ago (2016-09-15 11:32:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2340233003/90001
4 years, 3 months ago (2016-09-15 12:00:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:90001)
4 years, 3 months ago (2016-09-15 12:11:58 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 12:12:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec62374ccd4aaf1a32bcf3cedb9bfbab6d189c65
Cr-Commit-Position: refs/heads/master@{#14233}

Powered by Google App Engine
This is Rietveld 408576698