Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: PRESUBMIT.py

Issue 2340233003: Reland of Add arraysize to rtc_base_approved. Remove dependency of audio_device on rtc_base. (Closed)
Patch Set: Add dependency on rtc_base. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 5101f27e940dea609c20ebbe87d4b45af08127b4..8619ac5b70a85de70f71b5c27a8b7c1aaf82ef96 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -235,6 +235,7 @@ def _CheckNoRtcBaseDeps(input_api, gyp_files, output_api):
violating_files = []
for f in gyp_files:
gyp_exceptions = (
+ 'audio_device.gypi',
'base_tests.gyp',
'desktop_capture.gypi',
'p2p.gyp',
@@ -260,6 +261,7 @@ def _CheckNoRtcBaseDepsGn(input_api, gn_files, output_api):
violating_files = []
for f in gn_files:
gn_exceptions = (
+ os.path.join('audio_device', 'BUILD.gn'),
os.path.join('base_tests', 'BUILD.gn'),
os.path.join('desktop_capture', 'BUILD.gn'),
os.path.join('p2p', 'BUILD.gn'),
« no previous file with comments | « no previous file | webrtc/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698