Remove name parameter from HistogramAdd function.

Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug builds.

Checking if pointer is null is also moved outside HistogramAdd function. Having it there is confusing since Chromium implementation doesn't have it there.

BUG=webrtc:6329
Committed: https://crrev.com/71b8393b6a8bfc0f778fb77ef166fb574e1fa25b
Cr-Commit-Position: refs/heads/master@{#14263}

[sakal, 2016-09-13 09:44:33]

Description was changed from

==========
WIP: UMA changes

BUG=webrtc:6329
==========

to

==========
This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

BUG=webrtc:6329
==========

[sakal, 2016-09-13 09:45:22]

Description was changed from

==========
This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

BUG=webrtc:6329
==========

to

==========
Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug
builds.

BUG=webrtc:6329
==========

[sakal, 2016-09-13 09:51:09]

Description was changed from

==========
Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug
builds.

BUG=webrtc:6329
==========

to

==========
Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug
builds.

Checking if pointer is null is also moved outside HistogramAdd function. Placing
it there is confusing since for example Chromium implementation doesn't have it
there.

BUG=webrtc:6329
==========

[sakal, 2016-09-13 09:51:52]

Description was changed from

==========
Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug
builds.

Checking if pointer is null is also moved outside HistogramAdd function. Placing
it there is confusing since for example Chromium implementation doesn't have it
there.

BUG=webrtc:6329
==========

to

==========
Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug
builds.

Checking if pointer is null is also moved outside HistogramAdd function. Placing
it there is confusing since Chromium implementation doesn't have it there.

BUG=webrtc:6329
==========

[sakal, 2016-09-13 09:54:44]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 09:54:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2016-09-13 09:56:36]

sakal@webrtc.org changed reviewers:
+ tommi@webrtc.org

[sakal, 2016-09-13 09:57:08]

Description was changed from

==========
Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug
builds.

Checking if pointer is null is also moved outside HistogramAdd function. Placing
it there is confusing since Chromium implementation doesn't have it there.

BUG=webrtc:6329
==========

to

==========
Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug
builds.

Checking if pointer is null is also moved outside HistogramAdd function. Having
it there is confusing since Chromium implementation doesn't have it there.

BUG=webrtc:6329
==========

[commit-bot: I haz the power, 2016-09-13 11:07:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 11:07:05]

Dry run: Try jobs failed on following builders:
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/1203)

[sakal, 2016-09-13 12:53:22]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 12:53:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-13 14:54:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 14:54:12]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[sakal, 2016-09-15 14:36:14]

PTAL

This needs to be landed first: https://codereview.chromium.org/2337913002/

[tommi, 2016-09-15 17:16:48]

lgtm

https://codereview.webrtc.org/2337883003/diff/40001/webrtc/api/android/jni/an...
File webrtc/api/android/jni/androidmetrics_jni.cc (right):

https://codereview.webrtc.org/2337883003/diff/40001/webrtc/api/android/jni/an...
webrtc/api/android/jni/androidmetrics_jni.cc:71: if (histogram) {
Would it be a programmer error if histogram is 0? If so, the check shouldn't be
needed

[sakal, 2016-09-15 19:31:03]

https://codereview.webrtc.org/2337883003/diff/40001/webrtc/api/android/jni/an...
File webrtc/api/android/jni/androidmetrics_jni.cc (right):

https://codereview.webrtc.org/2337883003/diff/40001/webrtc/api/android/jni/an...
webrtc/api/android/jni/androidmetrics_jni.cc:71: if (histogram) {
On 2016/09/15 17:16:48, tommi (webrtc) wrote:
> Would it be a programmer error if histogram is 0? If so, the check shouldn't
be
> needed 

No, this can happen in other cases as well. HistogramFactoryGet* returns null if
UMA stats are not enabled.

[sakal, 2016-09-15 19:31:04]

https://codereview.webrtc.org/2337883003/diff/40001/webrtc/api/android/jni/an...
File webrtc/api/android/jni/androidmetrics_jni.cc (right):

https://codereview.webrtc.org/2337883003/diff/40001/webrtc/api/android/jni/an...
webrtc/api/android/jni/androidmetrics_jni.cc:71: if (histogram) {
On 2016/09/15 17:16:48, tommi (webrtc) wrote:
> Would it be a programmer error if histogram is 0? If so, the check shouldn't
be
> needed 

No, this can happen in other cases as well. HistogramFactoryGet* returns null if
UMA stats are not enabled.

[tommi, 2016-09-15 21:15:12]

On 2016/09/15 19:31:04, sakal wrote:
>
https://codereview.webrtc.org/2337883003/diff/40001/webrtc/api/android/jni/an...
> File webrtc/api/android/jni/androidmetrics_jni.cc (right):
> 
>
https://codereview.webrtc.org/2337883003/diff/40001/webrtc/api/android/jni/an...
> webrtc/api/android/jni/androidmetrics_jni.cc:71: if (histogram) {
> On 2016/09/15 17:16:48, tommi (webrtc) wrote:
> > Would it be a programmer error if histogram is 0? If so, the check shouldn't
> be
> > needed 
> 
> No, this can happen in other cases as well. HistogramFactoryGet* returns null
if
> UMA stats are not enabled.

OK, thanks for the explanation. Lgtm as is then.

[sakal, 2016-09-16 09:33:33]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-09-16 09:33:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-16 11:34:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 11:34:22]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[sakal, 2016-09-16 13:48:53]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-09-16 13:49:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-16 13:56:17]

Description was changed from

==========
Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug
builds.

Checking if pointer is null is also moved outside HistogramAdd function. Having
it there is confusing since Chromium implementation doesn't have it there.

BUG=webrtc:6329
==========

to

==========
Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug
builds.

Checking if pointer is null is also moved outside HistogramAdd function. Having
it there is confusing since Chromium implementation doesn't have it there.

BUG=webrtc:6329
==========

[commit-bot: I haz the power, 2016-09-16 13:56:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 13:56:24]

Description was changed from

==========
Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug
builds.

Checking if pointer is null is also moved outside HistogramAdd function. Having
it there is confusing since Chromium implementation doesn't have it there.

BUG=webrtc:6329
==========

to

==========
Remove name parameter from HistogramAdd function.

This name is only used for a DCHECK. Having it as a parameter leads to
unnecessary string copying even on release builds.

This CL instead adds a GetHistogramName function that is only called on debug
builds.

Checking if pointer is null is also moved outside HistogramAdd function. Having
it there is confusing since Chromium implementation doesn't have it there.

BUG=webrtc:6329

Committed: https://crrev.com/71b8393b6a8bfc0f778fb77ef166fb574e1fa25b
Cr-Commit-Position: refs/heads/master@{#14263}
==========

[commit-bot: I haz the power, 2016-09-16 13:56:25]

Patchset 3 (id:??) landed as
https://crrev.com/71b8393b6a8bfc0f778fb77ef166fb574e1fa25b
Cr-Commit-Position: refs/heads/master@{#14263}