Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Side by Side Diff: webrtc/api/android/jni/androidmetrics_jni.cc

Issue 2337883003: Remove name parameter from HistogramAdd function. (Closed)
Patch Set: Add check to Android Metrics. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/system_wrappers/include/metrics.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 61
62 JOW(jlong, Metrics_00024Histogram_nativeCreateCounts) 62 JOW(jlong, Metrics_00024Histogram_nativeCreateCounts)
63 (JNIEnv* jni, jclass, jstring j_name, jint min, jint max, jint buckets) { 63 (JNIEnv* jni, jclass, jstring j_name, jint min, jint max, jint buckets) {
64 std::string name = JavaToStdString(jni, j_name); 64 std::string name = JavaToStdString(jni, j_name);
65 return jlongFromPointer( 65 return jlongFromPointer(
66 webrtc::metrics::HistogramFactoryGetCounts(name, min, max, buckets)); 66 webrtc::metrics::HistogramFactoryGetCounts(name, min, max, buckets));
67 } 67 }
68 68
69 JOW(void, Metrics_00024Histogram_nativeAddSample) 69 JOW(void, Metrics_00024Histogram_nativeAddSample)
70 (JNIEnv* jni, jclass, jlong histogram, jint sample) { 70 (JNIEnv* jni, jclass, jlong histogram, jint sample) {
71 HistogramAdd(reinterpret_cast<webrtc::metrics::Histogram*>(histogram), 71 if (histogram) {
tommi 2016/09/15 17:16:48 Would it be a programmer error if histogram is 0?
sakal 2016/09/15 19:31:03 No, this can happen in other cases as well. Histog
72 sample); 72 HistogramAdd(reinterpret_cast<webrtc::metrics::Histogram*>(histogram),
73 sample);
74 }
73 } 75 }
74 76
75 } // namespace webrtc_jni 77 } // namespace webrtc_jni
OLDNEW
« no previous file with comments | « no previous file | webrtc/system_wrappers/include/metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698