Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. | 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. |
| 3 * | 3 * |
| 4 * Use of this source code is governed by a BSD-style license | 4 * Use of this source code is governed by a BSD-style license |
| 5 * that can be found in the LICENSE file in the root of the source | 5 * that can be found in the LICENSE file in the root of the source |
| 6 * tree. An additional intellectual property rights grant can be found | 6 * tree. An additional intellectual property rights grant can be found |
| 7 * in the file PATENTS. All contributing project authors may | 7 * in the file PATENTS. All contributing project authors may |
| 8 * be found in the AUTHORS file in the root of the source tree. | 8 * be found in the AUTHORS file in the root of the source tree. |
| 9 */ | 9 */ |
| 10 | 10 |
| (...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 61 | 61 |
| 62 JOW(jlong, Metrics_00024Histogram_nativeCreateCounts) | 62 JOW(jlong, Metrics_00024Histogram_nativeCreateCounts) |
| 63 (JNIEnv* jni, jclass, jstring j_name, jint min, jint max, jint buckets) { | 63 (JNIEnv* jni, jclass, jstring j_name, jint min, jint max, jint buckets) { |
| 64 std::string name = JavaToStdString(jni, j_name); | 64 std::string name = JavaToStdString(jni, j_name); |
| 65 return jlongFromPointer( | 65 return jlongFromPointer( |
| 66 webrtc::metrics::HistogramFactoryGetCounts(name, min, max, buckets)); | 66 webrtc::metrics::HistogramFactoryGetCounts(name, min, max, buckets)); |
| 67 } | 67 } |
| 68 | 68 |
| 69 JOW(void, Metrics_00024Histogram_nativeAddSample) | 69 JOW(void, Metrics_00024Histogram_nativeAddSample) |
| 70 (JNIEnv* jni, jclass, jlong histogram, jint sample) { | 70 (JNIEnv* jni, jclass, jlong histogram, jint sample) { |
| 71 HistogramAdd(reinterpret_cast<webrtc::metrics::Histogram*>(histogram), | 71 if (histogram) { |
|
tommi
2016/09/15 17:16:48
Would it be a programmer error if histogram is 0?
sakal
2016/09/15 19:31:03
No, this can happen in other cases as well. Histog
| |
| 72 sample); | 72 HistogramAdd(reinterpret_cast<webrtc::metrics::Histogram*>(histogram), |
| 73 sample); | |
| 74 } | |
| 73 } | 75 } |
| 74 | 76 |
| 75 } // namespace webrtc_jni | 77 } // namespace webrtc_jni |
| OLD | NEW |