Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2337463002:
Fixed video_loopback target. (Closed)
DescriptionFixed video_loopback target.
Moved it inside the rtc_include_tests if clause
so that it build only when tests flag is set to true.
NOTRY=True
BUG=31425205
Committed: https://crrev.com/bb723e53b4a1ef20b6e8ad9f97310d941ebaa3ed
Cr-Commit-Position: refs/heads/master@{#14197}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Moved video_loopback target to already existing if block #
Total comments: 1
Patch Set 3 : Remove build_with_chromium if check since its true inside include_tests #Messages
Total messages: 17 (7 generated)
Description was changed from ========== Fixed video_loopback target. Moved it inside the rtc_include_tests if clause so that it build only when tests flag is set to true. BUG=31425205 ========== to ========== Fixed video_loopback target. Moved it inside the rtc_include_tests if clause so that it build only when tests flag is set to true. BUG=31425205 ==========
charujain@webrtc.org changed reviewers: + kjellander@google.com, phoglund@webrtc.org
charujain@webrtc.org changed reviewers: + kjellander@webrtc.org - kjellander@google.com
For move-only CLs like this, please use NOTRY=True in the CL description and manually run just a few trybots. https://codereview.webrtc.org/2337463002/diff/1/webrtc/BUILD.gn File webrtc/BUILD.gn (right): https://codereview.webrtc.org/2337463002/diff/1/webrtc/BUILD.gn#newcode298 webrtc/BUILD.gn:298: testonly = true Please move this target down to the already existing section at line 411.
https://codereview.webrtc.org/2337463002/diff/1/webrtc/BUILD.gn File webrtc/BUILD.gn (right): https://codereview.webrtc.org/2337463002/diff/1/webrtc/BUILD.gn#newcode298 webrtc/BUILD.gn:298: testonly = true On 2016/09/13 09:21:25, kjellander_webrtc wrote: > Please move this target down to the already existing section at line 411. Done.
https://codereview.webrtc.org/2337463002/diff/20001/webrtc/BUILD.gn File webrtc/BUILD.gn (right): https://codereview.webrtc.org/2337463002/diff/20001/webrtc/BUILD.gn#newcode712 webrtc/BUILD.gn:712: if (!build_with_chromium) { Please remove the whole if(!build_with_chromium) block. It's true inside include_tests normally so it just makes things more complicated.
On 2016/09/13 11:30:51, kjellander_webrtc wrote: > https://codereview.webrtc.org/2337463002/diff/20001/webrtc/BUILD.gn > File webrtc/BUILD.gn (right): > > https://codereview.webrtc.org/2337463002/diff/20001/webrtc/BUILD.gn#newcode712 > webrtc/BUILD.gn:712: if (!build_with_chromium) { > Please remove the whole if(!build_with_chromium) block. It's true inside > include_tests normally so it just makes things more complicated. Done
On 2016/09/13 11:35:19, charujain wrote: > On 2016/09/13 11:30:51, kjellander_webrtc wrote: > > https://codereview.webrtc.org/2337463002/diff/20001/webrtc/BUILD.gn > > File webrtc/BUILD.gn (right): > > > > https://codereview.webrtc.org/2337463002/diff/20001/webrtc/BUILD.gn#newcode712 > > webrtc/BUILD.gn:712: if (!build_with_chromium) { > > Please remove the whole if(!build_with_chromium) block. It's true inside > > include_tests normally so it just makes things more complicated. > > Done lgtm Set NOTRY=True in the CL description and submit if the trybots are green.
On 2016/09/13 11:35:19, charujain wrote: > On 2016/09/13 11:30:51, kjellander_webrtc wrote: > > https://codereview.webrtc.org/2337463002/diff/20001/webrtc/BUILD.gn > > File webrtc/BUILD.gn (right): > > > > https://codereview.webrtc.org/2337463002/diff/20001/webrtc/BUILD.gn#newcode712 > > webrtc/BUILD.gn:712: if (!build_with_chromium) { > > Please remove the whole if(!build_with_chromium) block. It's true inside > > include_tests normally so it just makes things more complicated. > > Done lgtm Set NOTRY=True in the CL description and submit if the trybots are green.
Description was changed from ========== Fixed video_loopback target. Moved it inside the rtc_include_tests if clause so that it build only when tests flag is set to true. BUG=31425205 ========== to ========== Fixed video_loopback target. Moved it inside the rtc_include_tests if clause so that it build only when tests flag is set to true. NOTRY=True BUG=31425205 ==========
The CQ bit was checked by charujain@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Fixed video_loopback target. Moved it inside the rtc_include_tests if clause so that it build only when tests flag is set to true. NOTRY=True BUG=31425205 ========== to ========== Fixed video_loopback target. Moved it inside the rtc_include_tests if clause so that it build only when tests flag is set to true. NOTRY=True BUG=31425205 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fixed video_loopback target. Moved it inside the rtc_include_tests if clause so that it build only when tests flag is set to true. NOTRY=True BUG=31425205 ========== to ========== Fixed video_loopback target. Moved it inside the rtc_include_tests if clause so that it build only when tests flag is set to true. NOTRY=True BUG=31425205 Committed: https://crrev.com/bb723e53b4a1ef20b6e8ad9f97310d941ebaa3ed Cr-Commit-Position: refs/heads/master@{#14197} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/bb723e53b4a1ef20b6e8ad9f97310d941ebaa3ed Cr-Commit-Position: refs/heads/master@{#14197} |
