Fixed video_loopback target.

webrtc/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 # TODO(kjellander): Rebase this to webrtc/build/common.gypi changes after r6330.
 
@@ skipping 265 matching lines @@
       ]
     }
 
     if (rtc_enable_protobuf) {
       defines += [ "ENABLE_RTC_EVENT_LOG" ]
       deps += [ ":rtc_event_log_proto" ]
     }
   }
 }
 
-if (!build_with_chromium) {
-  rtc_executable("webrtc_tests") {
-    testonly = true
-    deps = [
-      ":webrtc",
-      "modules/video_capture:video_capture_internal_impl",
-      "test",
-    ]
-  }
-
-  rtc_executable("video_loopback") {
-    testonly = true
-    sources = [
-      "test/run_test.h",
-      "video/video_loopback.cc",
-    ]
-
-    if (is_mac) {
-      sources += [ "test/mac/run_test.mm" ]
-    } else {
-      sources += [ "test/run_test.cc" ]
-    }
-    deps = [
-      ":video_quality_test",
-      "system_wrappers:metrics_default",
-      "test:field_trial",
-      "test:test_common",
-      "test:test_renderer",
-      "//testing/gmock",
-      "//testing/gtest",
-      "//third_party/gflags",
-    ]
-    if (is_clang && !is_nacl) {
-      # Suppress warnings from Chrome's Clang plugins.
-      # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
-      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-    }
-  }
-}
-
 rtc_source_set("webrtc_common") {
   sources = [
     "common_types.cc",
     "common_types.h",
     "config.cc",
     "config.h",
     "engine_configurations.h",
     "typedefs.h",
   ]
 
@@ skipping 406 matching lines @@
   if (is_ios) {
     bundle_data("webrtc_perf_tests_bundle_data") {
       testonly = true
       sources = webrtc_perf_tests_resources
       outputs = [
         "{{bundle_resources_dir}}/{{source_file_part}}",
       ]
     }
   }
 
+  if (!build_with_chromium) {

[kjellander_webrtc, 2016/09/13 11:30:51]

Please remove the whole if(!build_with_chromium) block. It's true inside
include_tests normally so it just makes things more complicated.

+    rtc_executable("webrtc_tests") {
+      testonly = true
+      deps = [
+        ":webrtc",
+        "modules/video_capture:video_capture_internal_impl",
+        "test",
+      ]
+    }
+
+    rtc_executable("video_loopback") {
+      testonly = true
+      sources = [
+        "test/run_test.h",
+        "video/video_loopback.cc",
+      ]
+
+      if (is_mac) {
+        sources += [ "test/mac/run_test.mm" ]
+      } else {
+        sources += [ "test/run_test.cc" ]
+      }
+      deps = [
+        ":video_quality_test",
+        "system_wrappers:metrics_default",
+        "test:field_trial",
+        "test:test_common",
+        "test:test_renderer",
+        "//testing/gmock",
+        "//testing/gtest",
+        "//third_party/gflags",
+      ]
+      if (is_clang && !is_nacl) {
+        # Suppress warnings from Chrome's Clang plugins.
+        # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
+        suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+      }
+    }
+  }
+
   rtc_test("webrtc_perf_tests") {
     testonly = true
     configs += [ ":rtc_unittests_config" ]
 
     sources = [
       "call/call_perf_tests.cc",
       "call/rampup_tests.cc",
       "call/rampup_tests.h",
       "modules/audio_coding/neteq/test/neteq_performance_unittest.cc",
       "modules/audio_processing/audio_processing_performance_unittest.cc",
@@ skipping 59 matching lines @@
     if (is_mac) {
       sources += [ "base/macsocketserver_unittest.cc" ]
     }
     if (is_clang) {
       # Suppress warnings from the Chromium Clang plugin.
       # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 }